Just trying to understand the code here; some very minor comments as I
go along.

partition_op_strategy returning int32 looks pretty ugly, and the calling
code is not super-intelligible either.  How about returning a value from
a new enum?

typedef PartClause is missing a struct name, as is our tradition.


> +                              * We don't a <> operator clause into a key 
> right away.

Missing a word there.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Reply via email to