Hi, On 2017-12-14 10:41:04 +0100, Fabien COELHO wrote: > - I do not think that updating pgbench arithmetic for managing integer > overflows is worth Andres Freund time. My guess is that most > script would not trigger client-side overflows, so the change would > be a no-op in practice.
It might not be if you view it in isolation (although I'm not convinced). The problem is that it has cost beyond pgbench. Due to pgbench's overflow handling I can't run make check on a build that has -ftrapv, which found several bugs already. I'd be happy if somebody else would tackle the issue, but I don't quite see it happening... Greetings, Andres Freund
