On Thu, Dec 14, 2017 at 08:51:06AM +0700, Ali Akbar wrote: > 2017-12-13 15:37 GMT+07:00 Amit Langote <langote_amit...@lab.ntt.co.jp>: > > > On 2017/12/13 15:59, Ali Akbar wrote: > > > > > > Thanks for the link to those thread. > > > > > > Judging from the discussion there, it will be a long way to prevent DROP > > > NOT NULL. > > > > Yeah, I remembered that discussion when writing my email, but was for some > > reason convinced that everything's fine even without the elaborate > > book-keeping of inheritance information for NOT NULL constraints. Thanks > > Michael for reminding. > > > > Patch for adding check in pg_upgrade. Going through git history, the check > for inconsistency in NOT NULL constraint has ben there since a long time > ago. In this patch the check will be applied for all old cluster version. > I'm not sure in which version was the release of table inheritance.
Here are some spelling and grammar fixes to that patch: but nullabe in its children: nullable child column is not market: marked with adding: by adding and restart: and restarting the problem columns: the problematic columns 9.5, 9.6, 10: 9.5, 9.6, and 10 restore, that will cause error.: restore phase of pg_upgrade, that would cause an error. Justin
