On 12/13/17 10:04 AM, Stephen Frost wrote:
Just to be clear- the new base backup code doesn't actually *do* the non-init fork removal, it simply doesn't include the non-init fork in the backup when there is an init fork, right?
It does *not* do the unlogged non-init fork removal. The code I refactored in reinit.c is about identifying the forks, not removing them. That code is reused to determine what to exclude from the backup.
I added the regression tests to ensure that the behavior of reinit.c is unchanged after the refactor.
We certainly wouldn't want a basebackup actually running around removing the main fork for unlogged tables on a running and otherwise healthy system. ;)
That would not be good. -- -David da...@pgmasters.net
