On 11/21/17 05:16, Martín Marqués wrote: > El 21/11/17 a las 04:56, Arthur Zakirov escribió: >> On Mon, Nov 20, 2017 at 04:45:48PM -0300, Martín Marqués wrote: >>> New version of patch, without the --batch-mode option and using isatty() >>> >> >> Great! >> >>> + fprintf(stderr, "waiting for checkpoint"); >>> + if (isatty(fileno(stderr))) >>> + fprintf(stderr, "\n"); >>> + else >>> + fprintf(stderr, "\r"); >> >> Here the condition should be inverted I think. The next condition should be >> used: >> >>> if (!isatty(fileno(stderr))) >>> ... >> >> Otherwise pg_basebackup will insert '\n' in terminal instead '\r'. > > Ups! Attached the corrected version.:) > > Nice catch. I completely missed that. Thanks.
Committed. I switched the if logic around even more, so that it is ! if (isatty(fileno(stderr))) ! fprintf(stderr, "\r"); ! else ! fprintf(stderr, "\n"); instead of ! if (!isatty(fileno(stderr))) ! fprintf(stderr, "\n"); ! else ! fprintf(stderr, "\r"); -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
