On Thu, Sep 21, 2017 at 2:52 AM, Andres Freund <and...@anarazel.de> wrote: > On 2017-09-19 12:57:33 +0300, Konstantin Knizhnik wrote: >> >> >> On 04.09.2017 23:52, Andres Freund wrote: >> > >> > Hi. That piece of code isn't particularly clear (and has a bug in the >> > submitted version), I'm revising it. >> >> ... >> > Yea, I've changed that already, although it's currently added earlier, >> > because the alignment is needed before, to access the column correctly. >> > I've also made number of efficiency improvements, primarily to access >> > columns with an absolute offset if all preceding ones are fixed width >> > not null columns - that is quite noticeable performancewise. >> > >> > >> Should I wait for new version of your patch or continue review of this code? > > I'll update the posted version later this week, sorry for the delay.
I know that you are working on this actively per the set of patches you have sent lately, but this thread has stalled, so I am marking it as returned with feedback. There is now only one CF entry to track this work: https://commitfest.postgresql.org/15/1285/. Depending on the work you are doing you may want to spawn a CF entry for each sub-item. Just an idea. -- Michael
