On Mon, Nov 20, 2017 at 9:01 PM, Ildar Musin <i.mu...@postgrespro.ru> wrote: > Hi all, > > While I was looking through the indexes code I got confused by couple of > macros - IndexTupleSize() and IndexTupleDSize() - which seem to do the same > thing with only difference that the first one takes pointer as an argument > while the second one takes struct. And in most cases IndexTupleDSize() is > used with dereferencing of index tuple where IndexTupleSize() would suit > perfectly. Is there a particular reason to have them both? I've made a patch > that removes IndexTupleDSize macro. All the tests have passed. >
+1. I was also once confused with these macros. I think this is a good cleanup. On a quick look, I don't see any problem with your changes. -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
