Tomas Vondra <tomas.von...@2ndquadrant.com> writes:
> while compiling on gcc 7.2.0 (on ARM), I got this warning:
> rangetypes_spgist.c: In function 'spg_range_quad_inner_consistent':
> rangetypes_spgist.c:559:29: warning: comparison between pointer and
> zero character constant [-Wpointer-compare]
> if (in->traversalValue != (Datum) 0)
> ^~
Huh. I wonder why 7.2.1 on Fedora isn't producing that warning.
> I believe we should simply treat the traversalValue as pointer, and
> change the condition to
> if (in->traversalValue)
Agreed, especially since it's done like that in spgscan.c and
geo_spgist.c.
regards, tom lane
