On Tue, Nov 14, 2017 at 10:01 AM, Peter Geoghegan <p...@bowt.ie> wrote: > On Tue, Nov 14, 2017 at 1:41 AM, Rushabh Lathia > <rushabh.lat...@gmail.com> wrote: >> Thanks Peter and Thomas for the review comments. > > No problem. More feedback:
I see that Robert just committed support for a parallel_leader_participation GUC. Parallel tuplesort should use this, too. It will be easy to adopt the patch to make this work. Just change the code within nbtsort.c to respect parallel_leader_participation, rather than leaving that as a compile-time switch. Remove the force_single_worker variable, and use !parallel_leader_participation in its place. The parallel_leader_participation docs will also need to be updated. -- Peter Geoghegan