Thomas Munro wrote: > > - There's a third possible problem related to boundary cases in > > SlruScanDirCbRemoveMembers, but I don't understand that one well > > enough to explain it. Maybe Thomas can jump in here and explain the > > concern. > > I noticed something in passing which is probably not harmful, and not > relevant to this bug report, it was just a bit confusing while > testing:
Another thing I noticed in passing is that SimpleLruDoesPhysicalFileExist uses SLRU_OPEN_FAILED in slru_errcase for the case where lseek() fails, rather than SLRU_SEEK_FAILED. This is probably completely harmless, because that's lseek(..., SEEK_END), but seems rather odd anyway. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-general mailing list (pgsql-general@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-general
