On 16.12.2024 21:24, Tomas Vondra wrote:
On 12/9/24 19:54, Tomas Vondra wrote:
On 12/8/24 16:00, Egor Rogov wrote:
Hi,
...
I've spotted another mention of B-tree being the only AM that supports
parallel builds: comment in src/backend/catalog/index.c. As this mention
is not visible to the users, I'd propose removing it altogether rather
than fixing it. Updated patch is attached.
Thanks for noticing this and the patches. You're right, this should have
been updated with the BRIN parallel builds. I'll get this committed
sometime the week.
I've pushed the doc fix, and backpatched it to PG 17.
Thanks so much, Tomas!
Please note that the comment in src/backend/catalog/index.c remains
unchanged:
--- a/src/backend/catalog/index.c
+++ b/src/backend/catalog/index.c
@@ -2988,8 +2988,7 @@ index_build(Relation heapRelation,
Assert(PointerIsValid(indexRelation->rd_indam->ambuildempty));
/*
- * Determine worker process details for parallel CREATE INDEX.
Currently,
- * only btree has support for parallel builds.
+ * Determine worker process details for parallel CREATE INDEX.
*
* Note that planner considers parallel safety for us.
*/
