On 2024/12/11 9:18, Michael Paquier wrote:
On Fri, Oct 18, 2024 at 02:25:15AM +0900, Fujii Masao wrote:The documentation in wal.sgml explains that old WAL files cannot be removed or recycled until they are archived (when WAL archiving is used) or replicated (when using replication slots). However, it did not mention that, similarly, old WAL files are also kept until they are summarized if WAL summarization is enabled. Attached patch adds that clarification to the documentation. Thought? @@ -643,6 +643,8 @@ until the situation is resolved. A slow or failed standby server that uses a replication slot will have the same effect (see <xref linkend="streaming-replication-slots"/>). + Similarly, if WAL summarization is enabled, old segments are kept + until they are summarized. </para>Sounds like a good idea to me. I'd suggest to add a link to runtime-config-wal-summarization as it is the first reference to WAL summarization in this file.
Yes, that sounds like a good idea. I've updated the patch accordingly. Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION
From b0d6ceb6799889e3d9269948342a249c67c71341 Mon Sep 17 00:00:00 2001 From: Fujii Masao <fu...@postgresql.org> Date: Thu, 12 Dec 2024 23:46:23 +0900 Subject: [PATCH v2] doc: Clarify old WAL files are kept until they are summarized. The documentation in wal.sgml explains that old WAL files cannot be removed or recycled until they are archived (when WAL archiving is used) or replicated (when using replication slots). However, it did not mention that, similarly, old WAL files are also kept until they are summarized if WAL summarization is enabled. This commit adds that clarification to the documentation. Back-patch to v17 where WAL summarization was added. Author: Fujii Masao Reviewed-by: Michael Paquier Discussion: https://postgr.es/m/fd0eb0a5-f43b-4e06-b450-cbca011b6...@oss.nttdata.com --- doc/src/sgml/wal.sgml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/src/sgml/wal.sgml b/doc/src/sgml/wal.sgml index a34cddb5ed..b908720ade 100644 --- a/doc/src/sgml/wal.sgml +++ b/doc/src/sgml/wal.sgml @@ -643,6 +643,9 @@ until the situation is resolved. A slow or failed standby server that uses a replication slot will have the same effect (see <xref linkend="streaming-replication-slots"/>). + Similarly, if <link linkend="runtime-config-wal-summarization"> + WAL summarization</link> is enabled, old segments are kept + until they are summarized. </para> <para> -- 2.47.0
