On Fri, Sep 13, 2024 at 07:39:13AM +0900, Michael Paquier wrote: > I am not so sure, TBH. One example: I know these values in > tablecmds.c for some time because that's an area I tend to focus on > for bug fixes, but forgot entirely about the SQL function in event > triggers that feed on it until I found your post. A comment in > event_trigger.h to mention the doc update would work for me. That > would be impossible to miss.
My apologies for the delay in replying here. I've looked back at your proposal in 0002 to mention the two functions in the main section for event triggers and to add a description of the reson values in the bitmap. After adding a comment in event_trigger.h to tell that the documentation needs to be kept in sync, the result looked OK so I have applied that down to 13. 1ad23335f36b got in the way for 12 with some conflicts. As it is going to be EOL in a few days, it does not really matter much. -- Michael
signature.asc
Description: PGP signature