On Wed, 2022-12-07 at 14:32 -0700, David G. Johnston wrote: > While I agree with the conclusion that the function signature is an example, > and having more than one for these is probably overkill, we can address the > OP's complaint quite easily by doing what we do in many other places, give > each parameter in the function signature a name. I've modified v9 to include > those and attach it here as v10. I do think this suffices as a response > to this complaint. > > Bikeshedding on the names for setval, and maybe an attempt to incorporate > the parameter name into the prose, can be considered, though.
Thanks for looking into that, and parameter names are fully sufficient to clarify the usage. Your patch is good, except that you forgot to add the link target on the CREATE SEQUENCE page. > My thoughts regarding incorporating pg_get_serial_sequence and usage of these > functions in a more common, GENERATED AS IDENTITY environment, can be > considered > in a separate thread should I or anyone else wish to do so. +1 Yours, Laurenz Albe
