On Sun, 2021-10-10 at 16:15 -0400, rir wrote: > On Fri, Oct 08, 2021 at 02:47:43PM +0200, Laurenz Albe wrote: > > On Thu, 2021-10-07 at 16:06 -0400, rir wrote: > > > > So I suggest that you change the syntax diagram to > > > > FETCH [ direction ] [ FROM | IN ] cursor_name > > > Then I agree that the "empty or" can be removed. > > > I remain of the opinion that the comments should be > > retained, but we can leave that for somebody else to > > decide. > > I accept your three points above. > > The MOVE synopsis shows the same parsing as I presented, > should it be changed in the same way (move a square bracket left to > be after <direction>)? My guess is yes, but I've never used an > SQL cursor. > > When this convo settles, I send a new patch. Probably > here in the group. If I have a few more, or a complex one, > I'll check out the other submission method.
Yes, I think that such a patch would meet with favor. Make sure to register it on the commitfest. To do that, it is better to send the patch to the -hackers list. The commitfest application won't find conversations on the -docs list. Yours, Laurenz Albe
