On Mon, 2021-09-27 at 14:31 -0400, Bruce Momjian wrote:
> On Fri, Sep  3, 2021 at 09:39:45PM +0200, Laurenz Albe wrote:
> > On Thu, 2021-05-27 at 08:59 +0200, Laurenz Albe wrote:
> > > On Thu, 2021-05-27 at 11:10 +0700, Anton Voloshin wrote:
> > > > So I guess the https://icu4c-demos.unicode.org/icu-bin/locexp link is 
> > > > still the proper one, and eventually it will be fixed. Anyway, the old 
> > > > link, https://ssl.icu-project.org/icu-bin/locexp, if one goes through 
> > > > "wrong domain in certificate" errors, still redirects to the same
> > > > https://icu4c-demos.unicode.org/icu-bin/locexp
> > > > 
> > > > I believe changing link in Postgres' docs is better than keeping the 
> > > > old 
> > > > one, even though they are currently both 404 one way or another. At 
> > > > least it would save people following that link from scary "Warning: 
> > > > Potential Security Risk Ahead" messages before properly 404-ing.
> > > 
> > > I suggest that we wait until the end of the June 2021 commitfest and 
> > > decide then.
> > > If it is still not fixed then, the second option is better - or we move 
> > > it to
> > > the next commitfest.
> > 
> > It is way past that time, and the link is still broken.
> > 
> > So I guess it would be the best to remove the link from the documentation.
> 
> Should we change it to a link to the locexp source?
> 
>         https://github.com/unicode-org/icu-demos/tree/main/locexp
> 
>         This is the source for the locale explorer CGI which is on IBM's
>         external website at:
>         
>             http://demo.icu-project.org/icu-bin/locexp

I had a look at that and tried to build the software from source.
It requires you to build ICU, and even then it failed to build for me.
The build documentation is not very detailed.
So I think we should not link to that.

I noticed that two more external links have moved.

Attached is a patch that fixes those links and removes the link to
the locale explorer.

Yours,
Laurenz Albe
From 10c33a90a946a4337e37e54293e539e6f8cd2954 Mon Sep 17 00:00:00 2001
From: Laurenz Albe <laurenz.a...@cybertec.at>
Date: Wed, 29 Sep 2021 12:09:18 +0200
Subject: [PATCH] Fix external ICU links

The links explaining ICU locales and ICU API details have moved.

Also, remove the link to the "ICU Locale Explorer", since it is
no longer available.  We could have added a link to the source
at https://github.com/unicode-org/icu-demos, but the build
documentation is not very detailed, and an attempt to build
failed due to missing headers of unspecified origin.

Author: Anton Voloshin
Reviewed-by: Laurenz Albe

Discussion: https://postgr.es/m/68f32992-7ba7-f797-2bb3-8851bd70d...@postgrespro.ru
---
 doc/src/sgml/charset.sgml | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/doc/src/sgml/charset.sgml b/doc/src/sgml/charset.sgml
index 05a6bf568f..f203c368c2 100644
--- a/doc/src/sgml/charset.sgml
+++ b/doc/src/sgml/charset.sgml
@@ -747,8 +747,8 @@ CREATE COLLATION german (provider = libc, locale = 'de_DE');
     set that is preloaded by <command>initdb</command>.  Users are encouraged
     to define their own collation objects that make use of these facilities to
     suit the sorting behavior to their requirements.
-    See <ulink url="http://userguide.icu-project.org/locale";></ulink>
-    and <ulink url="http://userguide.icu-project.org/collation/api";></ulink> for
+    See <ulink url="https://unicode-org.github.io/icu/userguide/locale/";></ulink>
+    and <ulink url="https://unicode-org.github.io/icu/userguide/collation/api.html";></ulink> for
     information on ICU locale naming.  The set of acceptable names and
     attributes depends on the particular ICU version.
    </para>
@@ -842,10 +842,6 @@ CREATE COLLATION german (provider = libc, locale = 'de_DE');
     subtag) can be found in
     the <ulink url="https://github.com/unicode-org/cldr/blob/master/common/bcp47/collation.xml";>CLDR
     repository</ulink>.
-    The <ulink url="https://ssl.icu-project.org/icu-bin/locexp";>ICU Locale
-    Explorer</ulink> can be used to check the details of a particular locale
-    definition.  The examples using the <literal>k*</literal> subtags require
-    at least ICU version 54.
    </para>
 
    <para>
-- 
2.31.1

Reply via email to