On 2021/06/16 12:39, shinya11.k...@nttdata.com wrote:
Hi,

I add argument type to postgres-fdw parameters in postgres-fdw.sgml.
I think this change is kind. Do you think?

I think this change would improve the postgres_fdw docs.

-     <term><literal>extensions</literal></term>
+     <term><literal>extensions</literal> (<type>enum</type>)</term>

Since each value in "extensions" parameter is not limitted like
shared_preload_libraries, its type should be "string"?

-     <term><literal>fdw_startup_cost</literal></term>
+     <term><literal>fdw_startup_cost</literal> (<type>double 
precision</type>)</term>
-     <term><literal>fdw_tuple_cost</literal></term>
+     <term><literal>fdw_tuple_cost</literal> (<type>double 
precision</type>)</term>

Since "floating point" is used for GUC docs, "floating point" should be
used for the sake of consistenty, instead?

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION


Reply via email to