"tanghy.f...@fujitsu.com" <tanghy.f...@fujitsu.com> writes:
> On Thursday, May 27, 2021 11:27 PM, Tom Lane <t...@sss.pgh.pa.us> wrote
>> No ... "patch -p1 <~/improve-pgservice-docs.patch" works fine for me.
> Oh, never tried "patch -p1" command before but it worked. Thanks!!
> BTW, here is my previous operation to apply your patch(failed, which is
> strange IMO)
> $ git apply --3way improve-pgservice-docs.patch
Yeah, "git apply" is extremely picky. I'm not sure we've ever figured out
all the reasons why it sometimes doesn't work. Good old "patch" pretty
much always works though.
> Attached a patch to combine the above fix in your patch.
> Also fixed a typo in install-windows.sgml.
> Also fixed pgbuffercache.sgml as Michael commented at [1].
LGTM, pushed with one minor additional tweak.
regards, tom lane
