---------- Forwarded message --------- From: Tomas Vondra <tomas.von...@enterprisedb.com> Date: Fri, Mar 12, 2021 at 11:33 PM Subject: Re: GROUP BY DISTINCT To: Vik Fearing <v...@postgresfriends.org>, Georgios Kokolatos < gkokola...@protonmail.com>, <pgsql-hack...@lists.postgresql.org> Cc: Erik Rijkers <e...@xs4all.nl>
Hi Vik, The patch seems quite ready, I have just two comments. 1) Shouldn't this add another <indexterm> for DISTINCT, somewhere in the documentation? Now the index points just to the SELECT DISTINCT part. ..... regards -- Tomas Vondra EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company After reading the above thread in hackers, I noticed that the index does not point to aggrgeate functions either and DISTINCT is not mentioned in the aggregate functions page either: https://www.postgresql.org/docs/current/functions-aggregate.html Shouldn't it be mentioned with an example of COUNT(DISTINCT ...) or aggregate_function(DISTINCT ...) in general ? Best regards Pantelis Theodosiou
