On 2020/04/28 17:15, Daniel Gustafsson wrote:
On 28 Apr 2020, at 07:22, Fujii Masao <masao.fu...@oss.nttdata.com> wrote:
On 2020/04/28 13:37, Michael Paquier wrote:
On Mon, Apr 27, 2020 at 12:16:41PM +0200, Daniel Gustafsson wrote:
Based on a recent conversation about backups I had I propose a small tweak to
the pg_basebackup documentation. Listing the user types in the reverse order
from today, putting superuser last, makes it IMO a little clearer that a
REPLICATION role is preferrable to using a superuser for running backups.
Makes sense to me. We do that in logical-replication.sgml as well as
pg_rewind.sgml (the latter outlines superuser rights last).
Seems there are other documentations having the similar description,
for example, pg_receivewal.sgml, func.sgml and high-availability.sgml.
Isn't it better to update also them at the same time?
That doe make sense. I've updated the places where I think a user configuring
the system might conceivably infer a preference from the order, but have left
the other ones as is.
Thanks for updating the patch! It looks good to me.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION