On Fri, Dec 27, 2019 at 05:44:10AM +0000, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/12/default-roles.html > Description: > > The title is wrong. The roles are not defaults; they are predefined and > privileged. The title suggests that a user should expect to be assigned > these roles. "21.5 Sub-Administrator Roles" would be accurate--improving > clarity over all and removing any need to explain why postgres is not in > this list of roles. >
Good points. I have developed the attached documentation patch which includes your ideas. -- Bruce Momjian <br...@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +
diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml index dcb58115af..136778cb8a 100644 --- a/doc/src/sgml/monitoring.sgml +++ b/doc/src/sgml/monitoring.sgml @@ -277,7 +277,7 @@ postgres 27093 0.0 0.0 30096 2752 ? Ss 11:34 0:00 postgres: ser existence of a session and its general properties such as its sessions user and database are visible to all users. Superusers and members of the built-in role <literal>pg_read_all_stats</literal> (see also <xref - linkend="default-roles"/>) can see all the information about all sessions. + linkend="predefined-roles"/>) can see all the information about all sessions. </para> <table id="monitoring-stats-dynamic-views-table"> diff --git a/doc/src/sgml/user-manag.sgml b/doc/src/sgml/user-manag.sgml index 66f162703d..4432ee266b 100644 --- a/doc/src/sgml/user-manag.sgml +++ b/doc/src/sgml/user-manag.sgml @@ -483,30 +483,30 @@ DROP ROLE doomed_role; </para> </sect1> - <sect1 id="default-roles"> - <title>Default Roles</title> + <sect1 id="predefined-roles"> + <title>Predefined Roles</title> - <indexterm zone="default-roles"> + <indexterm zone="predefined-roles"> <primary>role</primary> </indexterm> <para> - <productname>PostgreSQL</productname> provides a set of default roles - which provide access to certain, commonly needed, privileged capabilities - and information. Administrators can GRANT these roles to users and/or - other roles in their environment, providing those users with access to - the specified capabilities and information. + <productname>PostgreSQL</productname> provides a set of predefined + roles which allow access to privileged capabilities and information. + Administrators can GRANT these roles to login and non-login roles, + providing those roles with access to the specified capabilities and + information. </para> <para> - The default roles are described in <xref linkend="default-roles-table"/>. - Note that the specific permissions for each of the default roles may + The predefined roles are described in <xref linkend="predefined-roles-table"/>. + Note that the specific permissions for each of the predefined roles may change in the future as additional capabilities are added. Administrators should monitor the release notes for changes. </para> - <table tocentry="1" id="default-roles-table"> - <title>Default Roles</title> + <table tocentry="1" id="predefined-roles-table"> + <title>Predefined Roles</title> <tgroup cols="2"> <thead> <row> @@ -565,8 +565,8 @@ DROP ROLE doomed_role; <literal>pg_read_all_stats</literal> and <literal>pg_stat_scan_tables</literal> roles are intended to allow administrators to easily configure a role for the purpose of monitoring the database server. They grant a set of common privileges - allowing the role to read various useful configuration settings, statistics and - other system information normally restricted to superusers. + allowing the role to read configuration settings, statistics, and other + system information normally restricted to superusers. </para> <para>