Fix detection of truncated compressed backups pg_verifybackup failed to detect truncated compressed tar backups for zstd, lz4 and gzip compression.
astreamer_zstd_decompressor checked whether ZSTD_decompressStream() returned an error. However, a positive return value at end-of-input means that the final zstd frame has not completed. Record the state and verify at finalization that zstd completed the frame. Also flush any pending internally buffered output before performing that check. astreamer_gzip_decompressor did not check whether inflate() had reached Z_STREAM_END before finalizing. Record whether inflate() completed the gzip stream, and reject finalization if it did not. astreamer_lz4_decompressor did not check whether LZ4F_decompress() completed the final frame before finalizing. Record the status of decompression and reject finalization unless the frame completed. This prevents pg_verifybackup from accepting a truncated compressed tar backup. Author: Chao Li <[email protected]> Co-authored-by: Daniel Gustafsson <[email protected]> Reviewed-by: Osama Abdul Qader <[email protected]> Reviewed-by: Zsolt Parragi <[email protected]> Reviewed-by: Japin Li <[email protected]> Discussion: https://postgr.es/m/[email protected] Backpatch-through: 19 Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/2566e51f47bb7020f170ac2ef228612227085b2d Modified Files -------------- src/bin/pg_verifybackup/t/010_client_untar.pl | 13 ++++++++ src/fe_utils/astreamer_gzip.c | 13 +++++++- src/fe_utils/astreamer_lz4.c | 13 ++++++++ src/fe_utils/astreamer_zstd.c | 46 +++++++++++++++++++++++++++ src/include/fe_utils/astreamer.h | 14 ++++++++ src/tools/pgindent/typedefs.list | 1 + 6 files changed, 99 insertions(+), 1 deletion(-)
