Fix for loop variables A number of for loops used loop variables that did not match the type of the end condition. This could lead to wraparound or signed/unsigned mismatches. Probably none of these are a problem in practice, but it's fragile code.
Reviewed-by: Tom Lane <[email protected]> Discussion: https://www.postgresql.org/message-id/flat/d639aede-209f-412b-927a-d38d4848b370%40eisentraut.org Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/e615da8cb21b3745456da45197fa5dc620f19dab Modified Files -------------- contrib/pageinspect/fsmfuncs.c | 5 ++- contrib/pageinspect/hashfuncs.c | 5 ++- contrib/pg_logicalinspect/pg_logicalinspect.c | 4 +-- contrib/pg_plan_advice/pgpa_identifier.c | 2 +- contrib/pg_plan_advice/pgpa_join.c | 3 +- contrib/pg_plan_advice/pgpa_output.c | 4 +-- contrib/pg_plan_advice/pgpa_walker.c | 2 +- contrib/pg_trgm/trgm_gist.c | 5 ++- src/backend/access/gin/ginget.c | 37 ++++++++++---------- src/backend/access/gin/ginlogic.c | 11 +++--- src/backend/access/gin/ginscan.c | 7 ++-- src/backend/access/nbtree/nbtpage.c | 2 +- src/backend/access/rmgrdesc/logicalmsgdesc.c | 2 +- src/backend/executor/execCurrent.c | 3 +- src/backend/jit/llvm/llvmjit.c | 4 +-- src/backend/lib/hyperloglog.c | 5 ++- src/backend/parser/parse_relation.c | 2 +- src/backend/parser/parse_target.c | 2 +- src/backend/port/win32/socket.c | 13 ++++---- src/backend/replication/logical/reorderbuffer.c | 11 +++--- src/backend/replication/logical/snapbuild.c | 5 +-- src/backend/statistics/dependencies.c | 34 ++++++++----------- src/backend/statistics/mcv.c | 39 ++++++++++------------ src/backend/statistics/mvdistinct.c | 14 ++++---- src/backend/storage/aio/aio_init.c | 2 +- src/backend/storage/aio/method_io_uring.c | 2 +- src/backend/storage/file/fd.c | 4 +-- src/backend/storage/ipc/shmem.c | 7 ++-- src/backend/storage/lmgr/lock.c | 10 +++--- src/backend/tsearch/spell.c | 3 +- src/backend/utils/adt/json.c | 2 +- src/backend/utils/adt/pg_dependencies.c | 2 +- src/backend/utils/adt/pg_locale.c | 6 ++-- src/backend/utils/adt/pg_locale_icu.c | 2 +- src/backend/utils/adt/pg_locale_libc.c | 2 +- src/backend/utils/adt/pg_ndistinct.c | 3 +- src/backend/utils/adt/selfuncs.c | 6 ++-- src/backend/utils/adt/tsgistidx.c | 5 ++- src/backend/utils/adt/tsquery.c | 7 ++-- src/backend/utils/adt/tsquery_gist.c | 5 ++- src/backend/utils/adt/varbit.c | 18 ++++------ .../mb/conversion_procs/euc_tw_and_big5/big5.c | 10 +++--- src/backend/utils/misc/injection_point.c | 4 +-- src/backend/utils/misc/pg_config.c | 3 +- src/backend/utils/mmgr/dsa.c | 21 ++++-------- src/backend/utils/resowner/resowner.c | 4 +-- src/backend/utils/time/snapmgr.c | 7 ++-- src/bin/pg_amcheck/pg_amcheck.c | 13 +++----- src/bin/pg_basebackup/pg_recvlogical.c | 3 +- src/bin/pg_combinebackup/reconstruct.c | 11 +++--- src/bin/pg_config/pg_config.c | 14 ++++---- src/bin/pg_ctl/pg_ctl.c | 6 ++-- src/bin/pg_dump/dumputils.c | 2 +- src/bin/pg_dump/pg_backup_archiver.c | 16 +++------ src/bin/psql/crosstabview.c | 11 +++--- src/common/hmac.c | 3 +- src/common/unicode_case.c | 4 +-- src/fe_utils/print.c | 4 +-- src/include/lib/radixtree.h | 14 ++++---- src/interfaces/ecpg/test/expected/sql-sqljson.c | 4 +-- src/interfaces/ecpg/test/sql/sqljson.pgc | 4 +-- src/interfaces/libpq-oauth/oauth-curl.c | 2 +- src/interfaces/libpq/fe-connect.c | 2 +- src/interfaces/libpq/win32.c | 5 ++- src/test/modules/test_aio/test_aio.c | 2 +- src/test/modules/test_binaryheap/test_binaryheap.c | 2 +- src/test/modules/test_escape/test_escape.c | 2 +- src/test/modules/test_integerset/test_integerset.c | 4 +-- src/test/modules/test_predtest/test_predtest.c | 3 +- src/test/modules/test_radixtree/test_radixtree.c | 8 ++--- 70 files changed, 211 insertions(+), 284 deletions(-)
