Reject ALTER TABLE .. CLUSTER earlier for partitioned tables ALTER TABLE .. CLUSTER ON and SET WITHOUT CLUSTER are not supported for partitioned tables and already fail with a check happening when the sub-command is executed, not when it is prepared.
This commit moves the relkind check for partitioned tables to happen when the sub-command is prepared in ATSimplePermissions(). This matches with the practice of the other sub-commands of ALTER TABLE, shaving one translatable string. mark_index_clustered() can be a bit simplified, switching one elog(ERROR) to an assertion. Note that mark_index_clustered() can also be called through a CLUSTER command, but it cannot be reached for a partitioned table, per the assertion based on the relkind in cluster_rel(), and there is only one caller of rebuild_relation(). Author: Chao Li <[email protected]> Reviewed-by: Michael Paquier <[email protected]> Reviewed-by: Zsolt Parragi <[email protected]> Discussion: https://postgr.es/m/caeowx2kggo1n2kdh6osfxhl_5gkg3dqq0pdnul4lh4xstkj...@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/c336133c65a7ac3223a3cb492b8bbf4fa3999375 Modified Files -------------- src/backend/commands/cluster.c | 6 +----- src/backend/commands/tablecmds.c | 2 +- src/test/regress/expected/cluster.out | 6 ++++-- 3 files changed, 6 insertions(+), 8 deletions(-)
