On Wed, Jun 20, 2012 at 05:53:14AM +0000, msrbugzi...@gmail.com wrote: > I observed a code clone in the following files. In the function > PGTYPESnumeric_copy, the variable dst is ensured to be not NULL before > passing to zero_var(). However, the function PGTYPESnumeric_from_decimal > does not perform this checking. It will cause an exception when dst is NULL > and passed to zero_var().
To be honest most of the functions do not check if the parameters are indeed set. Of course we could easily add the chekc for variable != NULL but that doesn't ensure that variable points to a valid numeric datatype. Suggestions? Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org Jabber: michael.meskes at googlemail dot com VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-bugs
