On Mon, Jun 4, 2012 at 8:48 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: >> In addition, error message above seems corrupted in my environment. >> Here we check not-escaped control character, so printing it with %c >> formatting might break log files. How about using decimal or hex dump >> in such cases? > > And so is that. IMO the error reporting in this module could stand to > be reviewed altogether for compliance with our message guidelines. > (For starters, why is it using errdetail_internal?) I refrained from > editorializing on-the-fly, but I'm not too pleased with what I saw.
Huh. I have no idea why I thought errdetail_internal was a good idea. Should we just change all those to errdetail? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-bugs
