The following bug has been logged online: Bug reference: 6060 Logged by: Shigehiro honda Email address: fwif0...@mb.infoweb.ne.jp PostgreSQL version: 9.1 beta2 Operating system: Linux Description: does not work -z option of pg_basebackup Details:
it seems that the -z option of pg_basebackup does not work correctly. In getopt_long() function, there is not 'z' in 3rd argument. And Z_DEFAULT_COMPRESSION are defined as (-1) in my zlib.h and it does only test (compresslevel > 0) in the code, so the command does not compress anyway. $ diff pg_basebackup.c.DIST pg_basebackup.c 267c267 < if (compresslevel > 0) --- > if (compresslevel > 0 || compresslevel == > Z_DEFAULT_COMPRESSION ) 284c284 < if (compresslevel > 0) --- > if (compresslevel > 0 || compresslevel == > Z_DEFAULT_COMPRESSION) 308c308 < if (compresslevel > 0) --- > if (compresslevel > 0 || compresslevel == Z_DEFAULT_COMPRESSION) 328c328 < if (compresslevel > 0) --- > if (compresslevel > 0 || compresslevel == Z_DEFAULT_COMPRESSION) 979c979 < while ((c = getopt_long(argc, argv, "D:F:l:Z:c:h:p:U:xwWvP", --- > while ((c = getopt_long(argc, argv, "D:F:l:Z:c:h:p:U:zxwWvP", 1092c1092 < if (format == 'p' && compresslevel > 0) --- > if (format == 'p' && ( compresslevel > 0|| compresslevel == Z_DEFAULT_COMPRESSION )) regards, -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-bugs
