"YAMAMOTO Takashi" <y...@mwd.biglobe.ne.jp> wrote: > a seemingly wrong math in OldSerXidAdd makes it busy writing zeros > to pg_serial. > > [patch] Your fix looks correct to me -- we want to get from a SLRU segment number to the first page of that segment, so SLRU_PAGES_PER_SEGMENT is the right multiplier. Thanks! While I was looking at it, I noticed some obsolete comment lines which should be removed. Trivial patch attached. -Kevin
*** a/src/backend/storage/lmgr/predicate.c --- b/src/backend/storage/lmgr/predicate.c *************** *** 722,731 **** OldSerXidInit(void) * Record a committed read write serializable xid and the minimum * commitSeqNo of any transactions to which this xid had a rw-conflict out. * A zero seqNo means that there were no conflicts out from xid. - * - * The return value is normally false -- true means that we're about to - * wrap around our space for tracking these xids, so the caller might want - * to take action to prevent that. */ static void OldSerXidAdd(TransactionId xid, SerCommitSeqNo minConflictCommitSeqNo) --- 722,727 ----
-- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-bugs
