On 9 June 2010 16:05, Robert Haas <robertmh...@gmail.com> wrote: > On Wed, Jun 9, 2010 at 11:03 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: >> Robert Haas <robertmh...@gmail.com> writes: >>> On Wed, Jun 9, 2010 at 9:35 AM, Dean Rasheed <dean.a.rash...@gmail.com> >>> wrote: >>>>> Does anyone care that Alias will sometimes be a string, and sometimes a >>>>> number? >> >>> After further review, it appears to me that this change is pretty much >>> required, because otherwise a string like 0xa won't be quoted. I >>> might think it's OK for "123" to turn into 123, but I'm not going to >>> be so happy about "0xa" turning into 10. Please test the attached >>> patch. >> >> I still agree with Dean's original proposal: always quote the values of >> strings. > > I'd still rather rip the format out entirely than do that. Dean's > proposal was based on the idea that it would be safe to quote only the > values and not the keys, which is not something I care to bank on. >
Why? There are only a small number of keys, and we're completely in control of them. You'd very quickly notice if one of them needed quoting, which is not the case with values. Dean -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-bugs