On Tue, Apr 6, 2010 at 21:55, Tom Lane <t...@sss.pgh.pa.us> wrote: > Magnus Hagander <mag...@hagander.net> writes: >> On Mon, Mar 29, 2010 at 11:47 AM, Takahiro Itagaki >> <itagaki.takah...@oss.ntt.co.jp> wrote: >>> A patch attached. The name of "PGMODULEEXPORT" might be arguable. > >> I agree with this in principle, but won't this break every single >> add-on module out there that supports Win32? > > The patch didn't touch the contrib modules, so why would it break > third-party sources?
Oh, d'oh. I was clearly too tired when reading that thing. I was thinking we required changes in the contrib modules/third party modules, but they don't actually use DLLEXPORT, do they? In that case, that argument clearly falls, and I'm in favour of the patch :-) Just make sure you test it on both current and semi-old versions of mingw, they tend to not always act the same way. Or just get it in and the buildfarm can figure that part out for us. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-bugs
