Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > I think this makes plenty of sense. However, something that occured to > > me just now is that perhaps the right thing to do in the long term is to > > put this message in errcontext and leave the "invalid value for XXX" as > > the main error message. That would probably involve attaching a > > errcontext callback and removing the complaint_level from this message > > altogether, letting the outer caller deal with it. > > errcontext wouldn't help --- by the time guc.c is ready to throw the > error, the assign hook isn't in the call stack anymore. We'd have to > invent some other special-purpose gizmo to make this work. > > Might be worth doing, but again, seems too big a change for 8.3.
Right -- your proposed fix seems fine for 8.3. -- Alvaro Herrera http://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support ---------------------------(end of broadcast)--------------------------- TIP 3: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq
