On Thu, 2007-07-12 at 19:36 +0000, ISHIDA Akio wrote:
> The following bug has been logged online:
> 
> Bug reference:      3439
> Operating system:   Windows XP
> Description:        pg_standby and path name with space
> Details: 
> 
> pg_standby failed if path name containing spaces.
> 
> C:\Documents and Settings\ishida\pgsql>pg_standby -d "C:\Documents and
> Settings\ ishida\pgsql\archive_dir" 000000010000000000000000 data\pg_xlog
> 
> Trigger file            : <not set>
> Waiting for WAL file    : C:\Documents and
> Settings\ishida\pgsql\archive_dir\000000010000000000000000
> WAL file path           : 000000010000000000000000
> Restoring to...         : data\pg_xlog
> Sleep interval          : 5 seconds
> Max wait interval       : 0 forever
> Command for restore     : copy C:\Documents and
> Settings\ishida\pgsql\archive_dir\000000010000000000000000 data\pg_xlog
> Num archived files kept : all files
> running restore         :The system cannot find the file specified.
> The system cannot find the file specified.
> The system cannot find the file specified.
> not restored            :

Magnus,

Looks to me like the following patch would fix the reported issue on
Windows:

> --- pg_standby.c        26 Jun 2007 22:05:02 -0000      1.6
> +++ pg_standby.c        12 Jul 2007 19:03:19 -0000
> @@ -69,7 +69,7 @@
>  int nextWALFileType;
> 
>  #define SET_RESTORE_COMMAND(cmd, arg1, arg2) \
> -       snprintf(restoreCommand, MAXPGPATH, cmd " %s %s", arg1, arg2)
> +       snprintf(restoreCommand, MAXPGPATH, cmd " \"%s\" \"%s\"", arg1,
> arg2)
> 
>  struct stat stat_buf;

-- 
  Simon Riggs
  EnterpriseDB  http://www.enterprisedb.com


---------------------------(end of broadcast)---------------------------
TIP 1: if posting/reading through Usenet, please send an appropriate
       subscribe-nomail command to [EMAIL PROTECTED] so that your
       message can get through to the mailing list cleanly

Reply via email to