> -----Original Message----- > From: Tom Lane [mailto:[EMAIL PROTECTED] > Sent: 02 August 2005 00:36 > To: Dave Page > Cc: pgsql-bugs@postgresql.org; [EMAIL PROTECTED] > Subject: Re: [BUGS] Libpq free bug? (Was: [ODBC] IIS Postgres > ASP ADO - Problem) > > "Dave Page" <dpage@vale-housing.co.uk> writes: > > Forwarded to -bugs in case it gets missed. > > This looks like it might be an issue to me, though I may well have > > overlooked something in my brief look at the code. > > There's nothing wrong with that code. The only modifiable > values in the > record are the "val" pointers, which are handled correctly. See the > comment: > > * PQconninfoOptions[] is a constant static array that we use > to initialize > * a dynamically allocated working copy. All the "val" fields in > * PQconninfoOptions[] *must* be NULL. In a working > copy, non-null "val" > * fields point to malloc'd strings that should be freed when > the working > * array is freed (see PQconninfoFree).
Ahh, missed that. Thanks Tom. Regards, Dave ---------------------------(end of broadcast)--------------------------- TIP 5: don't forget to increase your free space map settings
