Matt Peterson <[EMAIL PROTECTED]> writes: > + if(value == 0) > + { > + /* elog(NOTICE, "array_iterator: value is null"); */ > + return (0); > + }
This patch is certainly wrong, as it will break array_iterator for non-pointer datatypes (no, I do not believe your assertion to the contrary). More to the point, inserting explicit tests for null is an obsolete approach; the preferred way to do things these days is to mark the SQL declarations of such functions with "isStrict". Would you instead update contrib/array to rely on isStrict? It'd be even nicer to update contrib/array to V1 calling conventions, but unless you are hitting 64-bit porting problems that may not do anything useful for you... regards, tom lane ---------------------------(end of broadcast)--------------------------- TIP 2: you can get off all lists at once with the unregister command (send "unregister YourEmailAddressHere" to [EMAIL PROTECTED])