I think Ctrl-R is good for refresh (like Firefox and other browsers) and Ctrl-Shift-C sounds fine, too.
For Cancel Query I'd suggest "Del" - it "deletes" the process.
For Terminate backend: Shift-Del - it "really delets" it, like pressing Shift-Del in Windows Explorer bypasses the Recycling Bin. Not sure about the commit/rollback buttons, but maybe Ctrl-S (save) for commit and Ctrl-Z (undo) for rollback?

It's not immediately clear what the different between Edit, Copy and Action, Copy is. Maybe rename Action, Copy to "Copy to query tool" or something?

I tested the "clear selection" thing. The selection is cleared when the selected process terminates and the cancel/terminate toolbar buttons don't do anything then, but they are still enabled. Would be nice to actually grey them out. Action, Copy also remains enabled and selecting that causes a segfault.


On 28/12/2012 3:04 AM, Guillaume Lelarge wrote:
On Thu, 2012-12-27 at 16:58 +0100, Guillaume Lelarge wrote:
On Tue, 2012-12-25 at 18:38 +1100, Evan Martin wrote:
Thanks, Guillaume. It's ticket 386, right?
Yes.

  Could you also add shortcut keys while you're at it?
Any ideas what shortcut keys you would like? I have six items:

  * Refresh (Ctrl-R?)
  * Copy query (Ctrl-Shift-C)
  * Cancel query (Ctrl-R?)
  * Terminate backend (Suppr?)
  * Commit prepared transaction
  * Rollback prepared transaction

  That would be more useful than the menu items
themselves. And it may be worth mentioning the whole "clear selection"
thing in the ticket so it doesn't get lost.

It's already done.

BTW, if you want to test it, it's available on my github repository
(https://github.com/gleu/pgadmin3.git), on the "ticket386" branch.




--
Sent via pgadmin-support mailing list (pgadmin-support@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-support

Reply via email to