From what I can tell, we don't have visual studio project files for anything in xtra/ - Dave, correct? That would be a prerequisite.
I'm not involved at all in the packaging, so I can't comment there - Dave, again? ;) //Magnus On Mon, Jan 17, 2011 at 22:41, Jeremy Palmer <jpal...@linz.govt.nz> wrote: > > Wow thanks for the patch Magnus - so fast! > > Patch looks great. Is it also possible to update the patch to include the > win32 executable into the packaging? i.e pkg/win32/src/pgadmin3.wxs > > Cheers > Jeremy > > -----Original Message----- > From: Magnus Hagander [mailto:mag...@hagander.net] > Sent: Tuesday, 18 January 2011 2:17 a.m. > To: Dave Page > Cc: Jeremy Palmer; Guillaume Lelarge; pgadmin-support@postgresql.org > Subject: Re: [pgadmin-support] Calling pgScript from the command line > > On Mon, Jan 17, 2011 at 07:46, Magnus Hagander <mag...@hagander.net> wrote: >> On Sun, Jan 16, 2011 at 23:02, Dave Page <dp...@pgadmin.org> wrote: >>> On Sun, Jan 16, 2011 at 9:50 PM, Jeremy Palmer <jpal...@linz.govt.nz> wrote: >>>> It would be really awesome for DBAs admins to be able to run pgscripts >>>> from the command line which have developed in pgadmin. Even better if the >>>> programme is distributed with the standard win32 download. >>>> >>>> Would it be possible to revive it and integrate xtra/pgScript into the >>>> pgadmin? >>> >>> Well it's already in the source tree, and already integrated into the >>> pgAdmin GUI. All that is needed is a patch to fix the bitrot. As >>> always, patches are welcome. >> >> Seems the first issue at least comes from patch >> 93834d477cd3fb91deacc0946ef845622fd6678d which removed our md5 >> support. But there seems to be other issues as well. If you (=Jeremy) >> want to look at this, that'd be great - if not, I can probably look at >> it, but not right now. >> >> (btw, we really should look at making it not compile pgscript twice - >> once for pgadmin and once for the one in xtra/. But that's something >> for another day :D) > > Here's a patch that seems to make it work. The issues were: > > * md5 no longer available - but also not needed, removed. > * qtIdent() was not available in commandline mode, but needed. This in > turn required db/keywords.c to be linked in. > > Comments/objections on patch? > > -- > Magnus Hagander > Me: http://www.hagander.net/ > Work: http://www.redpill-linpro.com/ > ______________________________________________________________________________________________________ > > This message contains information, which is confidential and may be subject > to legal privilege. > If you are not the intended recipient, you must not peruse, use, disseminate, > distribute or copy this message. > If you have received this message in error, please notify us immediately > (Phone 0800 665 463 or i...@linz.govt.nz) and destroy the original message. > LINZ accepts no responsibility for changes to this email, or for any > attachments, after its transmission from LINZ. > > Thank you. > ______________________________________________________________________________________________________ > -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgadmin-support mailing list (pgadmin-support@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-support
