Fixes following code smell reported by SonarQube: 1) Replace this if-then-else flow by a single return statement 2) Remove the unnecessary boolean literals.
Branch ------ master Details ------- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b8f63adf411e9c6f1382dcc9f888c9a3a89f86b5 Modified Files -------------- .../databases/extensions/static/js/extension.ui.js | 6 +- .../publications/static/js/publication.ui.js | 29 +++----- .../schemas/collations/static/js/collation.ui.js | 8 +-- .../static/js/domain_constraints.ui.js | 5 +- .../foreign_tables/static/js/foreign_table.ui.js | 18 ++--- .../schemas/functions/static/js/function.ui.js | 38 +++------- .../functions/static/js/trigger_function.js | 5 +- .../functions/static/js/trigger_function.ui.js | 21 ++---- .../packages/edbfuncs/static/js/edbfunc.ui.js | 9 +-- .../schemas/packages/static/js/package.js | 8 +-- .../schemas/sequences/static/js/sequence.js | 5 +- .../servers/databases/schemas/static/js/schema.js | 16 ++--- .../schemas/synonyms/static/js/synonym.js | 8 +-- .../schemas/tables/columns/static/js/column.ui.js | 36 +++------- .../static/js/compound_trigger.js | 8 +-- .../static/js/check_constraint.ui.js | 15 +--- .../static/js/exclusion_constraint.ui.js | 10 +-- .../foreign_key/static/js/foreign_key.ui.js | 15 +--- .../index_constraint/static/js/primary_key.js | 17 ++--- .../index_constraint/static/js/primary_key.ui.js | 15 +--- .../static/js/unique_constraint.ui.js | 17 ++--- .../schemas/tables/indexes/static/js/index.ui.js | 15 ++-- .../tables/partitions/static/js/partition.ui.js | 26 ++----- .../static/js/row_security_policy.js | 6 +- .../static/js/row_security_policy.ui.js | 15 +--- .../schemas/tables/rules/static/js/rule.ui.js | 10 +-- .../schemas/tables/static/js/partition.utils.ui.js | 84 ++++++---------------- .../databases/schemas/tables/static/js/table.js | 10 +-- .../databases/schemas/tables/static/js/table.ui.js | 61 ++++------------ .../tables/triggers/static/js/trigger.ui.js | 34 ++------- .../databases/schemas/types/static/js/type.ui.js | 10 +-- .../databases/schemas/views/static/js/view.ui.js | 5 +- .../servers/databases/static/js/database.js | 14 ++-- .../subscriptions/static/js/subscription.ui.js | 19 ++--- .../server_groups/servers/static/js/server.js | 56 +++++---------- .../server_groups/servers/static/js/vacuum.ui.js | 21 ++---- .../server_groups/static/js/server_group.js | 10 +-- web/pgadmin/browser/static/js/datamodel.js | 11 ++- .../misc/cloud/static/js/azure_schema.ui.js | 10 +-- .../cloud/static/js/cloud_db_details_schema.ui.js | 8 +-- web/pgadmin/static/js/SchemaView/base_schema.ui.js | 10 +-- .../codemirror/addon/fold/pgadmin-sqlfoldcode.js | 5 +- web/pgadmin/static/js/components/PgTable.jsx | 5 +- web/pgadmin/tools/backup/static/js/backup.ui.js | 8 +-- .../static/js/import_export_selection.ui.js | 5 +- web/pgadmin/tools/psql/static/js/psql_module.js | 6 +- .../static/js/UserManagementDialog.jsx | 18 ++--- 47 files changed, 193 insertions(+), 598 deletions(-)
