Fixed an issue where the user is unable to update column-level privileges from the security tab. Fixes #6117
Branch ------ master Details ------- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2036e9d9a8587374af450b5522932af0ce29f2f0 Author: Rahul Shirsat <rahul.shir...@enterprisedb.com> Modified Files -------------- docs/en_US/release_notes_5_0.rst | 1 + .../templates/functions/pg/sql/11_plus/update.sql | 6 +- .../templates/functions/pg/sql/12_plus/update.sql | 6 +- .../templates/functions/pg/sql/9.2_plus/update.sql | 4 + .../templates/functions/pg/sql/9.5_plus/update.sql | 6 +- .../templates/functions/pg/sql/9.6_plus/update.sql | 6 +- .../templates/functions/pg/sql/default/update.sql | 6 +- .../functions/ppas/sql/12_plus/update.sql | 6 +- .../functions/ppas/sql/9.2_plus/update.sql | 4 + .../functions/ppas/sql/9.5_plus/update.sql | 6 +- .../functions/ppas/sql/9.6_plus/update.sql | 6 +- .../templates/procedures/pg/sql/11_plus/update.sql | 6 +- .../procedures/ppas/sql/11_plus/update.sql | 6 +- .../procedures/ppas/sql/9.5_plus/update.sql | 4 + .../procedures/ppas/sql/9.6_plus/update.sql | 4 + .../trigger_functions/pg/sql/11_plus/update.sql | 6 +- .../trigger_functions/pg/sql/9.2_plus/update.sql | 4 + .../trigger_functions/pg/sql/9.5_plus/update.sql | 6 +- .../trigger_functions/pg/sql/default/update.sql | 5 + .../11_plus/alter_function_change_grantee_acl.msql | 3 + .../11_plus/alter_function_change_grantee_acl.sql | 21 + .../pg/11_plus/alter_proc_change_grantee_priv.msql | 13 + .../pg/11_plus/alter_proc_change_grantee_priv.sql | 18 + .../functions/tests/pg/11_plus/test_function.json | 53 +- .../tests/pg/11_plus/test_procedures.json | 86 +++- .../12_plus/alter_function_change_grantee_acl.msql | 3 + .../12_plus/alter_function_change_grantee_acl.sql | 21 + .../pg/12_plus/alter_proc_change_grantee_priv.msql | 13 + .../pg/12_plus/alter_proc_change_grantee_priv.sql | 18 + .../functions/tests/pg/12_plus/test_function.json | 53 +- .../tests/pg/12_plus/test_procedures.json | 86 +++- .../alter_function_change_grantee_acl.msql | 3 + .../9.5_plus/alter_function_change_grantee_acl.sql | 21 + .../functions/tests/pg/9.5_plus/test_function.json | 53 +- .../alter_function_change_grantee_acl.msql | 3 + .../9.6_plus/alter_function_change_grantee_acl.sql | 21 + .../functions/tests/pg/9.6_plus/test_function.json | 53 +- .../11_plus/alter_function_change_grantee_acl.msql | 3 + .../11_plus/alter_function_change_grantee_acl.sql | 21 + .../11_plus/alter_proc_change_grantee_priv.msql | 13 + .../11_plus/alter_proc_change_grantee_priv.sql | 18 + .../tests/ppas/11_plus/test_function.json | 51 ++ .../tests/ppas/11_plus/test_procedures.json | 86 +++- .../12_plus/alter_function_change_grantee_acl.msql | 3 + .../12_plus/alter_function_change_grantee_acl.sql | 21 + .../12_plus/alter_proc_change_grantee_priv.msql | 13 + .../12_plus/alter_proc_change_grantee_priv.sql | 18 + .../tests/ppas/12_plus/test_function.json | 53 +- .../tests/ppas/12_plus/test_procedures.json | 86 +++- .../alter_function_change_grantee_acl.msql | 3 + .../9.5_plus/alter_function_change_grantee_acl.sql | 21 + .../tests/ppas/9.5_plus/test_function.json | 53 +- .../alter_function_change_grantee_acl.msql | 3 + .../9.6_plus/alter_function_change_grantee_acl.sql | 21 + .../9.6_plus/alter_proc_change_grantee_priv.msql | 13 + .../9.6_plus/alter_proc_change_grantee_priv.sql | 18 + .../tests/ppas/9.6_plus/test_function.json | 53 +- .../tests/ppas/9.6_plus/test_procedures.json | 34 ++ .../templates/sequences/sql/default/update.sql | 4 + .../pg/default/alter_seq_change_grantee_privs.sql | 19 + .../alter_seq_change_grantee_privs_msql.sql | 2 + .../tests/pg/default/alter_seq_privs_remove.sql | 2 - .../tests/pg/default/test_sequences_pg.json | 46 +- .../default/alter_seq_change_grantee_privs.sql | 19 + .../alter_seq_change_grantee_privs_msql.sql | 2 + .../tests/ppas/default/alter_seq_privs_remove.sql | 2 - .../tests/ppas/default/test_sequences_ppas.json | 46 +- .../pg/10_plus/alter_column_alt_privilege.msql | 2 + .../pg/10_plus/alter_column_alt_privilege.sql | 13 + .../tests/{ => pg}/10_plus/alter_column_char.msql | 0 .../tests/{ => pg}/10_plus/alter_column_char.sql | 0 .../10_plus/alter_column_drop_identity.msql | 0 .../10_plus/alter_column_drop_identity.sql | 0 .../alter_column_drop_identity_by_default.msql | 0 .../alter_column_drop_identity_by_default.sql | 0 .../{ => pg}/10_plus/alter_column_identity.msql | 0 .../{ => pg}/10_plus/alter_column_identity.sql | 0 .../10_plus/alter_column_identity_by_default.msql | 0 .../10_plus/alter_column_identity_by_default.sql | 0 .../alter_column_identity_for_comb_start_seq.msql | 0 .../alter_column_identity_for_comb_start_seq.sql | 0 .../alter_column_identity_for_restart_seq.msql | 0 .../alter_column_identity_for_restart_seq.sql | 0 .../tests/{ => pg}/10_plus/alter_column_int.msql | 0 .../tests/{ => pg}/10_plus/alter_column_int.sql | 0 .../{ => pg}/10_plus/alter_column_numeric.msql | 0 .../{ => pg}/10_plus/alter_column_numeric.sql | 0 .../10_plus/alter_column_remove_length.msql | 0 .../10_plus/alter_column_remove_length.sql | 0 .../tests/{ => pg}/10_plus/create_column_char.msql | 0 .../tests/{ => pg}/10_plus/create_column_char.sql | 0 .../create_column_identity_for_restart_seq.msql | 0 .../create_column_identity_for_restart_seq.sql | 0 .../tests/{ => pg}/10_plus/create_column_int.msql | 0 .../tests/{ => pg}/10_plus/create_column_int.sql | 0 .../10_plus/create_column_int_identity.msql | 0 .../10_plus/create_column_int_identity.sql | 0 .../create_column_int_identity_by_default.msql | 0 .../create_column_int_identity_by_default.sql | 0 .../{ => pg}/10_plus/create_column_numeric.msql | 0 .../{ => pg}/10_plus/create_column_numeric.sql | 0 .../columns/tests/{ => pg}/10_plus/test.json | 34 ++ .../pg/12_plus/alter_column_alt_privilege.msql | 2 + .../pg/12_plus/alter_column_alt_privilege.sql | 13 + .../tests/{ => pg}/12_plus/alter_column_char.msql | 0 .../tests/{ => pg}/12_plus/alter_column_char.sql | 0 .../12_plus/alter_column_drop_identity.msql | 0 .../12_plus/alter_column_drop_identity.sql | 0 .../alter_column_drop_identity_by_default.msql | 0 .../alter_column_drop_identity_by_default.sql | 0 .../{ => pg}/12_plus/alter_column_generated.msql | 0 .../{ => pg}/12_plus/alter_column_generated.sql | 0 ...ter_column_generated_with_existing_columns.msql | 0 ...lter_column_generated_with_existing_columns.sql | 0 .../{ => pg}/12_plus/alter_column_identity.msql | 0 .../{ => pg}/12_plus/alter_column_identity.sql | 0 .../12_plus/alter_column_identity_by_default.msql | 0 .../12_plus/alter_column_identity_by_default.sql | 0 .../alter_column_identity_for_comb_start_seq.msql | 0 .../alter_column_identity_for_comb_start_seq.sql | 0 .../alter_column_identity_for_restart_seq.msql | 0 .../alter_column_identity_for_restart_seq.sql | 0 .../tests/{ => pg}/12_plus/alter_column_int.msql | 0 .../tests/{ => pg}/12_plus/alter_column_int.sql | 0 .../{ => pg}/12_plus/alter_column_numeric.msql | 0 .../{ => pg}/12_plus/alter_column_numeric.sql | 0 .../12_plus/alter_column_remove_length.msql | 0 .../12_plus/alter_column_remove_length.sql | 0 .../tests/{ => pg}/12_plus/create_column_char.msql | 0 .../tests/{ => pg}/12_plus/create_column_char.sql | 0 .../create_column_identity_for_restart_seq.msql | 0 .../create_column_identity_for_restart_seq.sql | 0 .../tests/{ => pg}/12_plus/create_column_int.msql | 0 .../tests/{ => pg}/12_plus/create_column_int.sql | 0 .../12_plus/create_column_int_generated.msql | 0 .../12_plus/create_column_int_generated.sql | 0 ...column_int_generated_with_existing_columns.msql | 0 ..._column_int_generated_with_existing_columns.sql | 0 .../12_plus/create_column_int_identity.msql | 0 .../12_plus/create_column_int_identity.sql | 0 .../create_column_int_identity_by_default.msql | 0 .../create_column_int_identity_by_default.sql | 0 .../{ => pg}/12_plus/create_column_numeric.msql | 0 .../{ => pg}/12_plus/create_column_numeric.sql | 0 .../columns/tests/{ => pg}/12_plus/test.json | 14 + .../pg/default/alter_column_alt_privilege.msql | 2 + .../pg/default/alter_column_alt_privilege.sql | 13 + .../tests/{ => pg}/default/alter_column_char.msql | 0 .../tests/{ => pg}/default/alter_column_char.sql | 0 .../tests/{ => pg}/default/alter_column_int.msql | 0 .../tests/{ => pg}/default/alter_column_int.sql | 0 .../{ => pg}/default/alter_column_numeric.msql | 0 .../{ => pg}/default/alter_column_numeric.sql | 0 .../default/alter_column_remove_length.msql | 0 .../default/alter_column_remove_length.sql | 0 .../tests/{ => pg}/default/create_column_char.msql | 0 .../tests/{ => pg}/default/create_column_char.sql | 0 .../tests/{ => pg}/default/create_column_int.msql | 0 .../tests/{ => pg}/default/create_column_int.sql | 0 .../{ => pg}/default/create_column_numeric.msql | 0 .../{ => pg}/default/create_column_numeric.sql | 0 .../columns/tests/{ => pg}/default/test.json | 14 + .../ppas/10_plus/alter_column_alt_privilege.msql | 2 + .../ppas/10_plus/alter_column_alt_privilege.sql | 13 + .../tests/ppas/10_plus/alter_column_char.msql | 15 + .../tests/ppas/10_plus/alter_column_char.sql | 17 + .../ppas/10_plus/alter_column_drop_identity.msql | 2 + .../ppas/10_plus/alter_column_drop_identity.sql | 11 + .../alter_column_drop_identity_by_default.msql | 2 + .../alter_column_drop_identity_by_default.sql | 9 + .../tests/ppas/10_plus/alter_column_identity.msql | 7 + .../tests/ppas/10_plus/alter_column_identity.sql | 11 + .../10_plus/alter_column_identity_by_default.msql | 8 + .../10_plus/alter_column_identity_by_default.sql | 9 + .../alter_column_identity_for_comb_start_seq.msql | 2 + .../alter_column_identity_for_comb_start_seq.sql | 9 + .../alter_column_identity_for_restart_seq.msql | 2 + .../alter_column_identity_for_restart_seq.sql | 9 + .../tests/ppas/10_plus/alter_column_int.msql | 9 + .../tests/ppas/10_plus/alter_column_int.sql | 11 + .../tests/ppas/10_plus/alter_column_numeric.msql | 9 + .../tests/ppas/10_plus/alter_column_numeric.sql | 15 + .../ppas/10_plus/alter_column_remove_length.msql | 2 + .../ppas/10_plus/alter_column_remove_length.sql | 15 + .../tests/ppas/10_plus/create_column_char.msql | 5 + .../tests/ppas/10_plus/create_column_char.sql | 9 + .../create_column_identity_for_restart_seq.msql | 5 + .../create_column_identity_for_restart_seq.sql | 9 + .../tests/ppas/10_plus/create_column_int.msql | 5 + .../tests/ppas/10_plus/create_column_int.sql | 9 + .../ppas/10_plus/create_column_int_identity.msql | 5 + .../ppas/10_plus/create_column_int_identity.sql | 9 + .../create_column_int_identity_by_default.msql | 5 + .../create_column_int_identity_by_default.sql | 9 + .../tests/ppas/10_plus/create_column_numeric.msql | 9 + .../tests/ppas/10_plus/create_column_numeric.sql | 13 + .../tables/columns/tests/ppas/10_plus/test.json | 531 ++++++++++++++++++++ .../ppas/12_plus/alter_column_alt_privilege.msql | 2 + .../ppas/12_plus/alter_column_alt_privilege.sql | 13 + .../tests/ppas/12_plus/alter_column_char.msql | 15 + .../tests/ppas/12_plus/alter_column_char.sql | 17 + .../ppas/12_plus/alter_column_drop_identity.msql | 2 + .../ppas/12_plus/alter_column_drop_identity.sql | 11 + .../alter_column_drop_identity_by_default.msql | 2 + .../alter_column_drop_identity_by_default.sql | 9 + .../tests/ppas/12_plus/alter_column_generated.msql | 7 + .../tests/ppas/12_plus/alter_column_generated.sql | 11 + ...ter_column_generated_with_existing_columns.msql | 7 + ...lter_column_generated_with_existing_columns.sql | 11 + .../tests/ppas/12_plus/alter_column_identity.msql | 7 + .../tests/ppas/12_plus/alter_column_identity.sql | 11 + .../12_plus/alter_column_identity_by_default.msql | 8 + .../12_plus/alter_column_identity_by_default.sql | 9 + .../alter_column_identity_for_comb_start_seq.msql | 2 + .../alter_column_identity_for_comb_start_seq.sql | 9 + .../alter_column_identity_for_restart_seq.msql | 2 + .../alter_column_identity_for_restart_seq.sql | 9 + .../tests/ppas/12_plus/alter_column_int.msql | 9 + .../tests/ppas/12_plus/alter_column_int.sql | 11 + .../tests/ppas/12_plus/alter_column_numeric.msql | 9 + .../tests/ppas/12_plus/alter_column_numeric.sql | 15 + .../ppas/12_plus/alter_column_remove_length.msql | 2 + .../ppas/12_plus/alter_column_remove_length.sql | 15 + .../tests/ppas/12_plus/create_column_char.msql | 5 + .../tests/ppas/12_plus/create_column_char.sql | 9 + .../create_column_identity_for_restart_seq.msql | 5 + .../create_column_identity_for_restart_seq.sql | 9 + .../tests/ppas/12_plus/create_column_int.msql | 5 + .../tests/ppas/12_plus/create_column_int.sql | 9 + .../ppas/12_plus/create_column_int_generated.msql | 5 + .../ppas/12_plus/create_column_int_generated.sql | 9 + ...column_int_generated_with_existing_columns.msql | 5 + ..._column_int_generated_with_existing_columns.sql | 9 + .../ppas/12_plus/create_column_int_identity.msql | 5 + .../ppas/12_plus/create_column_int_identity.sql | 9 + .../create_column_int_identity_by_default.msql | 5 + .../create_column_int_identity_by_default.sql | 9 + .../tests/ppas/12_plus/create_column_numeric.msql | 9 + .../tests/ppas/12_plus/create_column_numeric.sql | 13 + .../tables/columns/tests/ppas/12_plus/test.json | 539 +++++++++++++++++++++ .../ppas/default/alter_column_alt_privilege.msql | 2 + .../ppas/default/alter_column_alt_privilege.sql | 13 + .../tests/ppas/default/alter_column_char.msql | 15 + .../tests/ppas/default/alter_column_char.sql | 17 + .../tests/ppas/default/alter_column_int.msql | 9 + .../tests/ppas/default/alter_column_int.sql | 11 + .../tests/ppas/default/alter_column_numeric.msql | 9 + .../tests/ppas/default/alter_column_numeric.sql | 15 + .../ppas/default/alter_column_remove_length.msql | 2 + .../ppas/default/alter_column_remove_length.sql | 15 + .../tests/ppas/default/create_column_char.msql | 5 + .../tests/ppas/default/create_column_char.sql | 9 + .../tests/ppas/default/create_column_int.msql | 5 + .../tests/ppas/default/create_column_int.sql | 9 + .../tests/ppas/default/create_column_numeric.msql | 9 + .../tests/ppas/default/create_column_numeric.sql | 13 + .../tables/columns/tests/ppas/default/test.json | 193 ++++++++ .../templates/columns/sql/10_plus/update.sql | 9 + .../templates/columns/sql/9.2_plus/update.sql | 9 + .../templates/columns/sql/default/update.sql | 9 + .../tables/templates/tables/sql/11_plus/update.sql | 4 + .../tables/templates/tables/sql/12_plus/update.sql | 4 + .../templates/tables/sql/9.6_plus/update.sql | 4 + .../tables/templates/tables/sql/default/update.sql | 4 + .../templates/schemas/pg/9.2_plus/sql/update.sql | 8 + .../templates/schemas/pg/default/sql/update.sql | 8 + .../templates/schemas/ppas/9.1_plus/sql/update.sql | 8 + .../templates/schemas/ppas/9.2_plus/sql/update.sql | 8 + .../tests/pg/9.2_plus/alter_schema_drop_priv.sql | 2 +- .../tests/pg/9.2_plus/alter_schema_update_priv.sql | 22 + .../pg/9.2_plus/alter_schema_update_priv_msql.sql | 12 + .../schemas/tests/pg/9.2_plus/test_schema.json | 46 +- .../tests/ppas/9.2_plus/alter_schema_drop_priv.sql | 2 +- .../ppas/9.2_plus/alter_schema_update_priv.sql | 22 + .../9.2_plus/alter_schema_update_priv_msql.sql | 14 + .../schemas/tests/ppas/9.2_plus/test_schema.json | 43 ++ .../types/templates/types/sql/default/update.sql | 4 + .../tests/pg/default/alter_acl_grantee_change.sql | 17 + .../pg/default/alter_acl_grantee_change_msql.sql | 2 + .../alter_composite_type_acl_description.msql | 0 .../alter_composite_type_acl_description.sql | 0 .../default/alter_composite_type_add_member.msql | 0 .../default/alter_composite_type_add_member.sql | 0 .../alter_composite_type_remove_member.msql | 0 .../default/alter_composite_type_remove_member.sql | 0 .../default/alter_enum_type_acl_description.msql | 0 .../default/alter_enum_type_acl_description.sql | 0 .../{ => pg}/default/alter_enum_type_label.msql | 0 .../{ => pg}/default/alter_enum_type_label.sql | 0 .../default/alter_range_type_acl_description.msql | 0 .../default/alter_range_type_acl_description.sql | 0 .../default/alter_shell_type_acl_description.msql | 0 .../default/alter_shell_type_acl_description.sql | 0 .../{ => pg}/default/create_composite_type.msql | 0 .../{ => pg}/default/create_composite_type.sql | 0 .../default/create_composite_type_one_field.sql | 0 .../tests/{ => pg}/default/create_enum_type.msql | 0 .../tests/{ => pg}/default/create_enum_type.sql | 0 .../tests/{ => pg}/default/create_range_type.msql | 0 .../tests/{ => pg}/default/create_range_type.sql | 0 .../tests/{ => pg}/default/create_shell_type.msql | 0 .../tests/{ => pg}/default/create_shell_type.sql | 0 .../types/tests/{ => pg}/default/tests.json | 51 ++ .../ppas/default/alter_acl_grantee_change.sql | 17 + .../ppas/default/alter_acl_grantee_change_msql.sql | 2 + .../alter_composite_type_acl_description.msql | 4 + .../alter_composite_type_acl_description.sql | 20 + .../default/alter_composite_type_add_member.msql | 2 + .../default/alter_composite_type_add_member.sql | 14 + .../alter_composite_type_remove_member.msql | 2 + .../default/alter_composite_type_remove_member.sql | 13 + .../default/alter_enum_type_acl_description.msql | 4 + .../default/alter_enum_type_acl_description.sql | 16 + .../tests/ppas/default/alter_enum_type_label.msql | 2 + .../tests/ppas/default/alter_enum_type_label.sql | 9 + .../default/alter_range_type_acl_description.msql | 4 + .../default/alter_range_type_acl_description.sql | 19 + .../default/alter_shell_type_acl_description.msql | 2 + .../default/alter_shell_type_acl_description.sql | 11 + .../tests/ppas/default/create_composite_type.msql | 6 + .../tests/ppas/default/create_composite_type.sql | 13 + .../default/create_composite_type_one_field.sql | 11 + .../types/tests/ppas/default/create_enum_type.msql | 2 + .../types/tests/ppas/default/create_enum_type.sql | 9 + .../tests/ppas/default/create_range_type.msql | 4 + .../types/tests/ppas/default/create_range_type.sql | 12 + .../tests/ppas/default/create_shell_type.msql | 1 + .../types/tests/ppas/default/create_shell_type.sql | 8 + .../schemas/types/tests/ppas/default/tests.json | 284 +++++++++++ .../templates/mviews/pg/9.3_plus/sql/update.sql | 4 + .../templates/mviews/pg/9.4_plus/sql/update.sql | 4 + .../templates/mviews/ppas/9.3_plus/sql/update.sql | 4 + .../templates/views/pg/9.1_plus/sql/update.sql | 4 + .../templates/views/pg/9.2_plus/sql/update.sql | 4 + .../templates/views/pg/9.3_plus/sql/update.sql | 4 + .../templates/views/pg/9.4_plus/sql/update.sql | 4 + .../templates/views/ppas/9.1_plus/sql/update.sql | 4 + .../templates/views/ppas/9.2_plus/sql/update.sql | 4 + .../templates/views/ppas/9.3_plus/sql/update.sql | 4 + .../templates/views/ppas/9.4_plus/sql/update.sql | 4 + .../9.4_plus/alter_mview_change_grantee_priv.sql | 17 + .../alter_mview_change_grantee_priv_msql.sql | 2 + .../tests/pg/9.4_plus/alter_view_delete_priv.sql | 1 - .../tests/pg/9.4_plus/alter_view_update_priv.sql | 19 + .../pg/9.4_plus/alter_view_update_priv_msql.sql | 2 + .../views/tests/pg/9.4_plus/test_mview.json | 57 +++ .../schemas/views/tests/pg/9.4_plus/tests.json | 71 ++- .../9.4_plus/alter_mview_change_grantee_priv.sql | 17 + .../alter_mview_change_grantee_priv_msql.sql | 2 + .../tests/ppas/9.4_plus/alter_view_delete_priv.sql | 2 - .../tests/ppas/9.4_plus/alter_view_update_priv.sql | 19 + .../ppas/9.4_plus/alter_view_update_priv_msql.sql | 2 + .../views/tests/ppas/9.4_plus/test_mview.json | 57 +++ .../schemas/views/tests/ppas/9.4_plus/tests.json | 65 +++ .../schemas/views/tests/view_test_data.json | 1 + .../server_groups/servers/static/js/privilege.js | 5 +- web/pgadmin/browser/server_groups/servers/utils.py | 14 +- 357 files changed, 4696 insertions(+), 45 deletions(-)