Hi, On Mon, Aug 3, 2020 at 3:06 PM Dave Page <dp...@pgadmin.org> wrote:
> > > On Mon, Aug 3, 2020 at 10:31 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi, >> >> On Fri, Jul 31, 2020 at 6:03 PM Dave Page <dp...@pgadmin.org> wrote: >> >>> Hi >>> >>> Currently, all the CodeMirrors in pgAdmin use the settings from the >>>> Query tool -> Editor, even though they're not related. I think you're >>>> right. We should move all CodeMirror settings out of the Query tool and >>>> move it to a new node - "SQL" may be. Editor and Auto-format would be sub >>>> nodes under SQL. With that, the editor settings will apply at all the >>>> places where CodeMirror editing is used(function body, query tool). What do >>>> you say ? >>>> >>> >>> Turns out that's more work than I really have time for at the moment, >>> because it means making the editors be able to handle automatic reloads of >>> multiple preference sections. We can always think about moving the >>> formatting preferences into their own section later. >>> >>> In the meantime, this update to the patch does what was originally >>> suggested and puts the options into a Query Tool -> SQL Formatting section. >>> >> Cool. >> >>> >>> Comments? Obviously docs will need updating too, once we're all happy >>> with the basics. >>> >> It works nice. A shortcut and auto format only selected text would be >> helpful. >> > > Yeah, the shortcut crossed my mind. Any thoughts on what it could be? I > was struggling to find something that made sense and wasn't used by Chrome > or elsewhere. > I can only find Shift+Cmd+K available. > > Formatting only the selected text might be troublesome; it may create some > very strange results if a partial statement is selected. > Formatter should not be blamed in that case. It did what was asked. :P > > Thanks. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EDB: http://www.enterprisedb.com > > -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain about Heat, Plant a TREE"
