1) Refactored code of columns node. Fixes #4938. 2) Fix an issue where length and precision are not removed from table/column dialog. Fixes #4964. 3) Fix an issue where the Interval data type is not displayed in the properties dialog of table/column. Fixes #4965. 4) Fix an issue where the wrong type is displayed when changing the datatype from timestamp with time zone to timestamp without time zone. Fixes #4761. 5) Change the label from 'Length and Precision' to 'Length/Precision and Scale' for columns. 6) The maximum length for datatype like interval, timestamp with time zone, time with time zone, etc.. is 6. Set the max length to 6 instead of 10.
Branch ------ master Details ------- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4fa1bdba5a7eb8f8bc6d3fb5992e2fa7a27aa08d Modified Files -------------- docs/en_US/column_dialog.rst | 2 +- docs/en_US/images/column_definition.png | Bin 44189 -> 51024 bytes docs/en_US/images/table_columns.png | Bin 45459 -> 64205 bytes docs/en_US/release_notes_4_16.rst | 4 + docs/en_US/table_dialog.rst | 6 +- .../servers/databases/schemas/tables/__init__.py | 77 +---- .../databases/schemas/tables/columns/__init__.py | 226 ++----------- .../schemas/tables/columns/static/js/column.js | 42 +-- .../columns/tests/10_plus/alter_column_char.sql | 2 +- .../columns/tests/10_plus/alter_column_numeric.sql | 2 +- .../tests/10_plus/alter_column_remove_length.sql | 15 + .../schemas/tables/columns/tests/10_plus/test.json | 13 +- .../columns/tests/12_plus/alter_column_char.sql | 2 +- .../columns/tests/12_plus/alter_column_numeric.sql | 2 +- .../tests/12_plus/alter_column_remove_length.sql | 15 + .../schemas/tables/columns/tests/12_plus/test.json | 13 +- .../columns/tests/default/alter_column_char.sql | 2 +- .../columns/tests/default/alter_column_numeric.sql | 2 +- .../tests/default/alter_column_remove_length.sql | 15 + .../schemas/tables/columns/tests/default/test.json | 13 +- .../tables/columns/tests/test_column_msql.py | 12 +- .../databases/schemas/tables/columns/utils.py | 360 +++++++++++++++++++++ .../schemas/tables/compound_triggers/utils.py | 2 +- .../tables/constraints/index_constraint/utils.py | 2 +- .../templates/columns/sql/10_plus/update.sql | 2 +- .../templates/columns/sql/9.2_plus/update.sql | 3 +- .../templates/columns/sql/default/update.sql | 2 +- .../databases/schemas/tables/triggers/utils.py | 2 +- .../servers/databases/schemas/tables/utils.py | 276 +--------------- .../databases/schemas/types/static/js/type.js | 8 +- .../types/macros/get_full_type_sql_format.macros | 33 +- .../servers/databases/schemas/utils.py | 18 +- 32 files changed, 571 insertions(+), 602 deletions(-)
