Hi Hackers, Attached is the updated patch with fixes.
On Mon, Jun 10, 2019 at 12:58 PM Akshay Joshi <akshay.jo...@enterprisedb.com> wrote: > Hi Aditya > > Following are the review comments: > > - "Set breakpoint" option not working, when click it throws an error. > > Fixed. > > - Create an empty function and try to debug that. It should show > proper error message. > > This seems to be a bug in the debugger itself. I'll raise a bug with simulation steps if it is. But, not sure where to raise. > > - Got the following backend error when closing the connection, please > fix this: > - File > "E:\Projects\pgadmin4\web\pgadmin\tools\debugger\__init__.py", line > 2053, > in close_debugger_session > conn_id=dbg_obj['exe_conn_id']) > > Fixed. > > On Fri, Jun 7, 2019 at 12:21 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch for debugger improvements. The changes include: >> 1) Change the way debug info is stored in session. Removed redundant >> session related code in debugger code. All the session related handling >> done at one place. >> 2) Fixed a bug where debugger was not opening for EPAS package function. >> 3) If a package is defined without body and we try to debug a proc/func, >> the debugger opened a blank window. Changes made so that it will throw >> error as "XYZ is not defined in package body." >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE"
RM4329_v2.patch
Description: Binary data