Hi On Wed, Mar 20, 2019 at 7:30 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote:
> Hi, > > Please find the attached patch to fix the RM #4030 - IDENTITY column not > recognised. > - Added support for IDENTITY column for PostgreSQL >= 10.0 > A few issues unfortunately: - There's an extra space in the generated SQL for an identity column on a table, right before the end comma (in both the CREATE and reverse engineered SQL. - I cannot make an IDENTITY column a primary key through the UI, nor does it reverse-engineer that property in the SQL if I create it via SQL (it does properly set the switch value though). - After creating an IDENTITY column, there should be a dependency on the sequence, but I don't see this listed. - We should consider the auto-created sequence a system object, and hide it in the treeview by default as it's an implementation detail. - If I click on an IDENTITY column in the treeview, the reverse-engineered SQL just shows the plain datatype. - Can we reasonably support the sequence_options clause? Thanks. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
