Ahh - ignore my previous email :-) Patch committed!
On Wed, Oct 31, 2018 at 11:09 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Please find the patch to fix the test cases. > As I can not reproduce the issue, I have fixed as per the logs. > > > > On Wed, Oct 31, 2018 at 4:01 PM Dave Page <dp...@pgadmin.org> wrote: > >> Thanks - patch applied! >> >> On Wed, Oct 31, 2018 at 10:05 AM Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find the attached updated patch. >>> >>> Thanks, >>> Khushboo >>> >>> On Mon, Oct 22, 2018 at 6:15 PM Akshay Joshi < >>> akshay.jo...@enterprisedb.com> wrote: >>> >>>> Hi Khushboo >>>> >>>> Following are the review comments: >>>> >>>> 1. There is difference in the colour of the two icons for Drop and >>>> Drop Cascade when both the button are disabled. Please refer >>>> Disabled_Icons. >>>> png. >>>> >>>> This will be taken care in the design changes. >>> >>>> >>>> 1. Delete/Drop and Drop Cascade button should not be enabled if >>>> none of the object is selected. >>>> >>>> Provided alert messages. >>> >>>> >>>> 1. >>>> 2. Databases: >>>> - When select all the databases including maintenance database >>>> it throws an error "Connection to the server has been lost". Please >>>> refer >>>> Database_Error.png >>>> - Checkbox should be disabled for maintenance database (if >>>> possible) >>>> >>>> Done >>> >>>> >>>> 1. Catalogs: >>>> - This feature should not be applicable to *Catalogs* and all >>>> there child nodes. >>>> >>>> Done >>> >>>> >>>> - >>>> 1. Roles: >>>> - When select all the roles and try to delete it, it throws an >>>> error "Current user can not be dropped". Can we specify the name of >>>> the >>>> current user in the error message? Please refer Role_Error.png >>>> - Checkbox should be disabled for current user (if possible) >>>> - When select all the roles except the current user, for some >>>> reason pgAdmin4 unable to delete one role then, rest of the roles >>>> are not >>>> deleted. Is this expected behaviour? >>>> 2. pgAgent Jobs: >>>> - Unable to Delete/Drop pgAgent Jobs. Please refer pgAgent_Jobs. >>>> png >>>> >>>> Done >>> >>>> >>>> 1. Document changes not included in the patch. >>>> >>>> Missed to attach in the previous patch. attached now. >>> >>>> >>>> 1. Following API test cases were failing: >>>> - EventTriggerMultipleDeleteTestCase (Fetch Event Trigger Node >>>> URL) >>>> - SchemaDeleteMultipleTestCase (Check Schema Node URL) >>>> - DatabaseMultipleDeleteTestCase (Check Databases Node URL) >>>> - ExtensionsDeleteMultipleTestCase (Check Extension Node) >>>> - CollationDeleteMultipleTestCase (Fetch collation Node URL) >>>> >>>> Error:- " flask.debughelpers.FormDataRoutingRedirect: b'A request was >>>> sent to this URL (http://localhost/browser/database/obj/1/5) but a >>>> redirect was issued automatically by the routing system to "http:// >>>> localhost/browser/database/obj/1/5/". The URL was defined with a >>>> trailing slash so Flask will automatically redirect to the URL with the >>>> trailing slash if it was accessed without one. Make sure to directly send >>>> your DELETE-request to this URL since we can\'t make browsers or HTTP >>>> clients redirect with form data reliably or without user interaction.\n\ >>>> nNote: this exception is only raised in debug mode". >>>> >>>> >>>> Can not reproduce at my end. >>> >>>> >>>> On Mon, Oct 22, 2018 at 11:36 AM Khushboo Vashi < >>>> khushboo.va...@enterprisedb.com> wrote: >>>> >>>>> Hi, >>>>> >>>>> Please find the attached updated patch. >>>>> >>>>> On Wed, Oct 17, 2018 at 7:58 PM Dave Page <dp...@pgadmin.org> wrote: >>>>> >>>>>> Hi >>>>>> >>>>>> Some relatively minor details to fix please: >>>>>> >>>>>> - There's no doc update. >>>>>> >>>>>> Done. >>>>> >>>>>> - I think fa-trash-alt might be better for the Drop icon. >>>>>> >>>>>> Done. >>>>> >>>>>> - I don't like the Drop Cascade icon. Maybe have Chethana create one >>>>>> based on fa-trash-alt, shrunken a little with a downwards pointing arrow >>>>>> on >>>>>> the bottom right. >>>>>> >>>>>> Done. >>>>> >>>>>> Thanks! >>>>>> >>>>>> Thanks, >>>>> Khushboo >>>>> >>>>>> On Tue, Oct 16, 2018 at 10:23 AM Khushboo Vashi < >>>>>> khushboo.va...@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi, >>>>>>> >>>>>>> Please find the attached updated patch with the following changes. >>>>>>> 1. Introduced header buttons for Drop and Drop Cascade >>>>>>> 2. Fixed checkbox alignment issue >>>>>>> 3. Refresh the grid on the error >>>>>>> >>>>>>> Currently I have removed multi delete table-space test case. I have >>>>>>> tried to create sub directories but didn't work due to permission issue. >>>>>>> >>>>>>> Thanks, >>>>>>> Khushboo >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> On Tue, Oct 9, 2018 at 3:35 PM Dave Page <dp...@pgadmin.org> wrote: >>>>>>> >>>>>>>> Hi >>>>>>>> >>>>>>>> On Tue, Oct 9, 2018 at 8:03 AM Khushboo Vashi < >>>>>>>> khushboo.va...@enterprisedb.com> wrote: >>>>>>>> >>>>>>>>> Hi Dave, >>>>>>>>> >>>>>>>>> On Mon, Oct 8, 2018 at 5:35 PM Dave Page <dp...@pgadmin.org> >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On Mon, Oct 8, 2018 at 12:50 PM Khushboo Vashi < >>>>>>>>>> khushboo.va...@enterprisedb.com> wrote: >>>>>>>>>> >>>>>>>>>>> Hi Dave, >>>>>>>>>>> >>>>>>>>>>> On Mon, Oct 8, 2018 at 3:47 PM Dave Page <dp...@pgadmin.org> >>>>>>>>>>> wrote: >>>>>>>>>>> >>>>>>>>>>>> Hi >>>>>>>>>>>> On Fri, Oct 5, 2018 at 12:28 PM Khushboo Vashi < >>>>>>>>>>>> khushboo.va...@enterprisedb.com> wrote: >>>>>>>>>>>> >>>>>>>>>>>>> Hi, >>>>>>>>>>>>> >>>>>>>>>>>>> Please find the attached updated patch with the fixes. >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Whenever I run the python tests, I get the following errors >>>>>>>>>>>> (even after manually deleting all test tablespaces): >>>>>>>>>>>> >>>>>>>>>>>> I am not getting this error. My test cases are passing >>>>>>>>>>> successfully. >>>>>>>>>>> Do you have this issue on particular server or all the server? >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> I'm just testing on PG10 at the moment (and have run the tests >>>>>>>>>> multiple times). >>>>>>>>>> >>>>>>>>>> >>>>>>>>>>> Which python version? >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> 3.6.6. >>>>>>>>>> >>>>>>>>>> >>>>>>>>> I have found the issue. >>>>>>>>> For every new table-space, different path is required. We give the >>>>>>>>> table-space path in the test_config.json file. >>>>>>>>> Now to test the multiple delete, we need to give multiple paths. >>>>>>>>> So, Should I configure the multiple paths in the test_config.json >>>>>>>>> file or skip the multile delete tablespace test case? >>>>>>>>> >>>>>>>> >>>>>>>> Can we create multiple sub-directories under the specified path? >>>>>>>> >>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> Khushboo >>>>>>>>> >>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> ====================================================================== >>>>>>>>>>>> >>>>>>>>>>>> ERROR: runTest >>>>>>>>>>>> (pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_delete_multiple.TableSpaceDeleteTestCase) >>>>>>>>>>>> >>>>>>>>>>>> Delete Multiple Tablespaces >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> ---------------------------------------------------------------------- >>>>>>>>>>>> >>>>>>>>>>>> Traceback (most recent call last): >>>>>>>>>>>> >>>>>>>>>>>> File >>>>>>>>>>>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tablespaces/tests/utils.py", >>>>>>>>>>>> line 59, in create_tablespace >>>>>>>>>>>> >>>>>>>>>>>> (test_tablespace_name, server['tablespace_path'])) >>>>>>>>>>>> >>>>>>>>>>>> psycopg2.OperationalError: directory >>>>>>>>>>>> "/Library/PostgreSQL/tablespaces/10/PG_10_201707211" already in >>>>>>>>>>>> use as a >>>>>>>>>>>> tablespace >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> During handling of the above exception, another exception >>>>>>>>>>>> occurred: >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Traceback (most recent call last): >>>>>>>>>>>> >>>>>>>>>>>> File >>>>>>>>>>>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tablespaces/tests/test_tbspc_delete_multiple.py", >>>>>>>>>>>> line 44, in setUp >>>>>>>>>>>> >>>>>>>>>>>> self.server, self.tablespace_names[1]) >>>>>>>>>>>> >>>>>>>>>>>> File >>>>>>>>>>>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tablespaces/tests/utils.py", >>>>>>>>>>>> line 74, in create_tablespace >>>>>>>>>>>> >>>>>>>>>>>> raise Exception("Error while creating tablespace. %s" % >>>>>>>>>>>> exception) >>>>>>>>>>>> >>>>>>>>>>>> Exception: Error while creating tablespace. directory >>>>>>>>>>>> "/Library/PostgreSQL/tablespaces/10/PG_10_201707211" already in >>>>>>>>>>>> use as a >>>>>>>>>>>> tablespace >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> ====================================================================== >>>>>>>>>>>> >>>>>>>>>>>> ERROR: runTest >>>>>>>>>>>> (pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_get.TablespaceGetTestCase) >>>>>>>>>>>> >>>>>>>>>>>> Check Tablespace Node >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> ---------------------------------------------------------------------- >>>>>>>>>>>> >>>>>>>>>>>> Traceback (most recent call last): >>>>>>>>>>>> >>>>>>>>>>>> File >>>>>>>>>>>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tablespaces/tests/utils.py", >>>>>>>>>>>> line 59, in create_tablespace >>>>>>>>>>>> >>>>>>>>>>>> (test_tablespace_name, server['tablespace_path'])) >>>>>>>>>>>> >>>>>>>>>>>> psycopg2.OperationalError: directory >>>>>>>>>>>> "/Library/PostgreSQL/tablespaces/10/PG_10_201707211" already in >>>>>>>>>>>> use as a >>>>>>>>>>>> tablespace >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> During handling of the above exception, another exception >>>>>>>>>>>> occurred: >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Traceback (most recent call last): >>>>>>>>>>>> >>>>>>>>>>>> File >>>>>>>>>>>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tablespaces/tests/test_tbspc_get.py", >>>>>>>>>>>> line 36, in setUp >>>>>>>>>>>> >>>>>>>>>>>> self.server, self.tablespace_name) >>>>>>>>>>>> >>>>>>>>>>>> File >>>>>>>>>>>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tablespaces/tests/utils.py", >>>>>>>>>>>> line 74, in create_tablespace >>>>>>>>>>>> >>>>>>>>>>>> raise Exception("Error while creating tablespace. %s" % >>>>>>>>>>>> exception) >>>>>>>>>>>> >>>>>>>>>>>> Exception: Error while creating tablespace. directory >>>>>>>>>>>> "/Library/PostgreSQL/tablespaces/10/PG_10_201707211" already in >>>>>>>>>>>> use as a >>>>>>>>>>>> tablespace >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> ====================================================================== >>>>>>>>>>>> >>>>>>>>>>>> ERROR: runTest >>>>>>>>>>>> (pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_put.TableSpaceUpdateTestCase) >>>>>>>>>>>> >>>>>>>>>>>> Check Tablespace Node >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> ---------------------------------------------------------------------- >>>>>>>>>>>> >>>>>>>>>>>> Traceback (most recent call last): >>>>>>>>>>>> >>>>>>>>>>>> File >>>>>>>>>>>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tablespaces/tests/utils.py", >>>>>>>>>>>> line 59, in create_tablespace >>>>>>>>>>>> >>>>>>>>>>>> (test_tablespace_name, server['tablespace_path'])) >>>>>>>>>>>> >>>>>>>>>>>> psycopg2.OperationalError: directory >>>>>>>>>>>> "/Library/PostgreSQL/tablespaces/10/PG_10_201707211" already in >>>>>>>>>>>> use as a >>>>>>>>>>>> tablespace >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> During handling of the above exception, another exception >>>>>>>>>>>> occurred: >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Traceback (most recent call last): >>>>>>>>>>>> >>>>>>>>>>>> File >>>>>>>>>>>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tablespaces/tests/test_tbspc_put.py", >>>>>>>>>>>> line 36, in setUp >>>>>>>>>>>> >>>>>>>>>>>> self.server, self.tablespace_name) >>>>>>>>>>>> >>>>>>>>>>>> File >>>>>>>>>>>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tablespaces/tests/utils.py", >>>>>>>>>>>> line 74, in create_tablespace >>>>>>>>>>>> >>>>>>>>>>>> raise Exception("Error while creating tablespace. %s" % >>>>>>>>>>>> exception) >>>>>>>>>>>> Exception: Error while creating tablespace. directory >>>>>>>>>>>> "/Library/PostgreSQL/tablespaces/10/PG_10_201707211" already in >>>>>>>>>>>> use as a >>>>>>>>>>>> tablespace >>>>>>>>>>>> >>>>>>>>>>>> -- >>>>>>>>>>>> Dave Page >>>>>>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>>>>>> Twitter: @pgsnake >>>>>>>>>>>> >>>>>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>>>>>>> The Enterprise PostgreSQL Company >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Dave Page >>>>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>>>> Twitter: @pgsnake >>>>>>>>>> >>>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>>>>> The Enterprise PostgreSQL Company >>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Dave Page >>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>> Twitter: @pgsnake >>>>>>>> >>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>>> The Enterprise PostgreSQL Company >>>>>>>> >>>>>>> >>>>>> >>>>>> -- >>>>>> Dave Page >>>>>> Blog: http://pgsnake.blogspot.com >>>>>> Twitter: @pgsnake >>>>>> >>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>> >>>> >>>> -- >>>> *Akshay Joshi* >>>> >>>> *Sr. Software Architect * >>>> >>>> >>>> >>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >>>> >>> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
