Hi, PFA minor patch to fix the issue, where user will get empty dialog in desktop mode if user clicks on pgadmin4 header logo. pgAdmin4 is already a SPA so in my opinion we don't require route to to home page. RM#2479
-- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
diff --git a/web/pgadmin/browser/templates/browser/index.html b/web/pgadmin/browser/templates/browser/index.html index 92950fd..63d696f 100644 --- a/web/pgadmin/browser/templates/browser/index.html +++ b/web/pgadmin/browser/templates/browser/index.html @@ -88,6 +88,9 @@ require.onResourceLoad = function (context, map, depMaps) { text-align: center; color: #fff; } +.pgadmin_header_logo { + cursor: default; +} </style> <div id="pg-spinner"> <div class="pg-sp-content"> @@ -104,7 +107,7 @@ require.onResourceLoad = function (context, map, depMaps) { <span class="icon-bar"></span> <span class="icon-bar"></span> </button> - <a class="navbar-brand" href="{{ '#' if config.SERVER_MODE else '?key=' + current_app.PGADMIN_KEY }}"> + <a class="navbar-brand pgadmin_header_logo" onClick="return false;" href="{{ '#' }}"> <i class="app-icon {{ config.APP_ICON }}"></i> <span> {{ config.APP_NAME }}</span> </a>