Satish Balay <[email protected]> writes: > On Fri, 13 Jun 2014, Jed Brown wrote: > >> We are testing for these now, but never call them since >> >> https://bitbucket.org/petsc/petsc/commits/9b5000abb3a60be67df1194dc2bfaf8b24ce60ad >> >> I think we should remove those tests. I wonder how many more configure >> tests can be removed because their result is unused. > > I can push this one..
Looks good to me.
> -----
>
> $ git diff config/PETSc/Configure.py config/PETSc/utilities/missing.py |cat
> diff --git a/config/PETSc/Configure.py b/config/PETSc/Configure.py
> index 6568904..d0f83a2 100644
> --- a/config/PETSc/Configure.py
> +++ b/config/PETSc/Configure.py
> @@ -103,7 +103,7 @@ class Configure(config.base.Configure):
> 'readlink', 'realpath', 'sigaction', 'signal', 'sigset',
> 'usleep', 'sleep', '_sleep', 'socket',
> 'times', 'gethostbyname',
> 'uname','snprintf','_snprintf','lseek','_lseek','time','fork','stricmp',
> 'strcasecmp', 'bzero', 'dlopen', 'dlsym', 'dlclose',
> 'dlerror','get_nprocs','sysctlbyname',
> - '_intel_fast_memcpy','_intel_fast_memset']
> + ]
> libraries1 = [(['socket', 'nsl'], 'socket'), (['fpe'], 'handle_sigfpes')]
> self.headers.headers.extend(headersC)
> self.functions.functions.extend(functions)
> diff --git a/config/PETSc/utilities/missing.py
> b/config/PETSc/utilities/missing.py
> index b02b3a7..29a2c72 100644
> --- a/config/PETSc/utilities/missing.py
> +++ b/config/PETSc/utilities/missing.py
> @@ -138,21 +138,6 @@ if (drand48_ptr() > 0.5) return 1;
> self.popLanguage()
> return
>
> - def configureMissingIntelFastPrototypes(self):
> - if self.functions.haveFunction('_intel_fast_memcpy'):
> - self.addPrototype('#include <stddef.h> \nvoid *_intel_fast_memcpy(void
> *,const void *,size_t);', 'C')
> - if hasattr(self.compilers, 'CXX'):
> - self.pushLanguage('C++')
> - self.addPrototype('#include <stddef.h> \nvoid
> *_intel_fast_memcpy(void *,const void *,size_t);', 'extern C')
> - self.popLanguage()
> - if self.functions.haveFunction('_intel_fast_memset'):
> - self.addPrototype('#include <stddef.h> \nvoid *_intel_fast_memset(void
> *, int, size_t);', 'C')
> - if hasattr(self.compilers, 'CXX'):
> - self.pushLanguage('C++')
> - self.addPrototype('#include <stddef.h> \nvoid
> *_intel_fast_memset(void *, int, size_t);', 'extern C')
> - self.popLanguage()
> - return
> -
> def configure(self):
> self.executeTest(self.configureMissingDefines)
> self.executeTest(self.configureMissingUtypeTypedefs)
> @@ -160,5 +145,4 @@ if (drand48_ptr() > 0.5) return 1;
> self.executeTest(self.configureMissingSignals)
> self.executeTest(self.configureMissingGetdomainnamePrototype)
> self.executeTest(self.configureMissingSrandPrototype)
> - self.executeTest(self.configureMissingIntelFastPrototypes)
> return
pgpseqttAoAon.pgp
Description: PGP signature
