Hi Edward,

On Thu, Jun 12, 2008 at 09:09:06PM +0100, Edward Kerr wrote:
> Andy,
> 
> How does this look?

Well, I'm no expert :)  It does look a bit better though.
Especially if you run it as non-root.

As I say I would also look into ways to do the update/login without
sending your password in clear over the Internet..

Only other thing I can think of is:

> #!/bin/sh

You probably should use #!/bin/bash as at least:

>                       ERROR=$(($ERROR-1))

that is bash-specific I believe, and /bin/sh isn't always bash (it
may be dash on Ubuntu for example).

Cheers,
Andy

-- 
http://bitfolk.com/ -- No-nonsense VPS hosting
Encrypted mail welcome - keyid 0x604DE5DB

Attachment: signature.asc
Description: Digital signature

_______________________________________________
Peterboro mailing list
Peterboro@mailman.lug.org.uk
https://mailman.lug.org.uk/mailman/listinfo/peterboro

Reply via email to