On Mon Jul 14 10:55:35 2008, doughera wrote: > Some of the new tests for auto::pack fail for me: > > $ perl t/harness -v t/steps/auto_pack-01.t > out 2>&1 > t/steps/auto_pack-01....# Failed test (t/steps/auto_pack-01.t at > line 101) > # Failed test (t/steps/auto_pack-01.t at line 102) > # '' > # doesn't match '(?-xism:Configure\.pl: Unable to find a suitable > packtype for intvalsize)' > # Failed test (t/steps/auto_pack-01.t at line 121) > # Failed test (t/steps/auto_pack-01.t at line 122) > # '' > # doesn't match '(?-xism:Configure\.pl: Unable to find a suitable > packtype for intvalsize)' > # Looks like you failed 4 tests of 33. > dubious > Test returned status 4 (wstat 1024, 0x400) > DIED. FAILED tests 14-17 > Failed 4/33 tests, 87.88% okay > Failed 1/1 test scripts, 0.00% okay. 4/33 subtests failed, 87.88% > okay. > Failed Test Stat Wstat Total Fail Failed List of Failed > ------------------------------------------------------------------------------- > t/steps/auto_pack-01.t 4 1024 33 4 12.12% 14-17 > >
1. This is a test that I wrote, so I would be interested in at least knowing which OS, platform, C-compiler combination you were using here. It might help me write better tests in the future. > > Rather than exhaustively testing the existing behavior of > config/auto/pack.pm, it would have been worthwhile to first to > consider > whether the existing behavior was worth maintaining. A quick > examination > shows that the config step is determing "types" for the perl "pack" > function, but these "types" are never used anywhere. They haven't > been > used for years. > 2. Apart from deleting the step, then running 'make' and 'make test', is there any other way to demonstrate that these types are not used? > The correct fix here is to simply delete the config step and its > associated tests. > 3. Are there any other configuration steps which are no longer needed? Thank you very much. kid51
