[perl #46625] [PATCH] config/auto/backtrace.pm: Eliminate one variable

[via RT]

# New Ticket Created by  James Keenan 
# Please include the string:  [perl #46625]
# in the subject line of all future correspondence about this issue. 
# <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=46625 >


The patch attached tightens up the code a bit in config/auto/ 
backtrace.pm.

I'll apply in 2-3 days if there is no objection.

Index: config/auto/backtrace.pm
===================================================================
--- config/auto/backtrace.pm    (revision 22382)
+++ config/auto/backtrace.pm    (working copy)
@@ -37,26 +37,20 @@
 
     cc_gen("config/auto/backtrace/test_c.in");
 
-    # If the program builds (e.g. the linker found backtrace* in libc) then we 
have
-    # the glibc backtrace symbols.  If the program fails to build for whatever
-    # reason we're just going to assume that the build failure is because these
-    # symbols are missing.
-    my $glibc_backtrace;
+    # If the program builds (e.g. the linker found backtrace* in libc)
+    # then we have the glibc backtrace symbols.  If the program fails to
+    # build for whatever reason we're just going to assume that the
+    # build failure is because these symbols are missing.
+
     eval { cc_build(); };
-    if ( not $@ ) {
-        $glibc_backtrace = 1;
+    if ( $@ ) {
+        $self->set_result("no");
+    } else {
+        $conf->data->set( glibc_backtrace => 1 );
+        $self->set_result("yes");
     }
     cc_clean();
 
-    $conf->data->set( glibc_backtrace => $glibc_backtrace, );
-
-    if ($glibc_backtrace) {
-        $self->set_result("yes");
-    }
-    else {
-        $self->set_result("no");
-    }
-
     return 1;
 }