On Aug 8, 2007, at 10:58 AM, [EMAIL PROTECTED] wrote:

-    INTVAL get_integer_keyed(PMC* key) {
+    INTVAL get_integer_keyed(PMC *key) {

As you go through these, please check to see if you can NOTNULL or NULLOK the parms that you're changing. For example this one:

-    PMC* get_pmc_keyed(PMC *key) {
+    PMC *get_pmc_keyed(PMC *key) {
         Hash *hash = (Hash *)PMC_struct_val(SELF);

         if ((PObj_get_FLAGS(key) & KEY_type_FLAGS) ==

PObj_get_FLAGS(key) is effectively a NOTNULL on key, so you can make the parm for get_pmc_keyed be NOTNULL(PMC *key).

Thanks,
xoxo,
Andy

--
Andy Lester => [EMAIL PROTECTED] => www.petdance.com => AIM:petdance




Reply via email to