On May 12, 2007, at 12:25 AM, chromatic wrote:

I agree. It may be a decent test, but it's not a test to run by default right
now.

While I'm asking for a pony, I'd also like a way to disable the coding
standards tests for an official release tarball.

-- c


This will at least take care of the second part. The end user probably won't care less if pod has a little bit of an error. Maybe using an environmental variable would help with some of the issues which tests to run and when.

Index: config/gen/makefiles/root.in
===================================================================
--- config/gen/makefiles/root.in        (revision 18511)
+++ config/gen/makefiles/root.in        (working copy)
@@ -1331,7 +1331,8 @@

# The --running-make-test argument is currently used by long-running tests
 # to disable GC_DEBUG.
-EXTRA_TEST_ARGS    = --gc-debug --running-make-test
+#INVERSE_CONDITIONED_LINE(DEVEL):EXTRA_TEST_ARGS = --gc-debug --running-make-test +#CONDITIONED_LINE(DEVEL):EXTRA_TEST_ARGS = --developing --gc-debug --running-make-test
 DISTRO_TEST_FILES = \
     t/distro/*.t
 BENCHMARK_TEST_FILES = \
Index: t/harness
===================================================================
--- t/harness   (revision 18511)
+++ t/harness   (working copy)
@@ -80,6 +80,11 @@

 Emit a C<smoke.html> file instead of displaying results.

+=item C<--developing>
+
+Run extra tests the check coding standards and other parts of parrot not
+essential for a successful build.
+
 =back

 =cut
@@ -111,6 +116,9 @@
 my $use_test_run = grep { $_ eq '--tr' } @ARGV;
 @ARGV = grep { $_ ne '--tr' } @ARGV;

+my $developing = grep { $_ eq '--developing' } @ARGV;
[EMAIL PROTECTED] = grep { $_ ne '--developing' } @ARGV;
+
 $use_test_run ||= $ENV{'PARROT_USE_TEST_RUN'};

 # Suck the short options into the TEST_PROG_ARGS evar:
@@ -153,34 +161,44 @@

# Pass in a list of tests to run on the command line, else run all the tests.
 my @default_tests = map {glob "t/$_/*.t"} qw(
- configure postconfigure compilers/imcc/* op pmc native_pbc dynpmc dynoplibs
+    postconfigure compilers/imcc/* op pmc native_pbc dynpmc dynoplibs
compilers/past compilers/pge compilers/pge/p5regex compilers/pge/p6regex - compilers/tge compilers/json library examples run src tools perl doc stm
+    compilers/tge compilers/json library examples run tools stm
 );

-# append the distribution checking tests to the default tests
-my @distro_tests = map { "t/distro/$_" } qw(
-    manifest.t
-    file_metadata.t
-);
-push @default_tests, @distro_tests;
+if ($developing) {
+    my @developing_tests;
+    @developing_tests = map {glob "t/$_/*.t" } qw(
+        configure src perl doc
+    );
+    push @default_tests, @developing_tests;

-# collect the coding standard tests (that we want to run) together and
-# append them to the list of default tests
-my @coding_std_tests = map { "t/codingstd/$_" } qw(
-    c_code_coda.t
-    c_header_guards.t
-    c_indent.t
-    c_struct.t
-    cppcomments.t
-    cuddled_else.t
-    gmt_utc.t
-    pir_code_coda.t
-    tabs.t
-    trailing_space.t
-);
-push @default_tests, @coding_std_tests;
+    # append the distribution checking tests to the default tests
+    my @distro_tests;
+    @distro_tests = map { "t/distro/$_" } qw(
+        manifest.t
+        file_metadata.t
+    );
+    push @default_tests, @distro_tests;

+ # collect the coding standard tests (that we want to run) together and
+    # append them to the list of default tests
+    my @coding_std_tests;
+    @coding_std_tests = map { "t/codingstd/$_" } qw(
+        c_code_coda.t
+        c_header_guards.t
+        c_indent.t
+        c_struct.t
+        cppcomments.t
+        cuddled_else.t
+        gmt_utc.t
+        pir_code_coda.t
+        tabs.t
+        trailing_space.t
+    );
+    push @default_tests, @coding_std_tests;
+}
+
 my @tests = @ARGV ? map { glob( $_ ) } @ARGV : @default_tests;

 if ($use_test_run) {

Reply via email to